Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: keep main-thread Isolate attached to platform during Dispose #31795

Closed
wants to merge 1 commit into from
Closed

src: keep main-thread Isolate attached to platform during Dispose #31795

wants to merge 1 commit into from

Commits on Feb 14, 2020

  1. src: keep main-thread Isolate attached to platform during Dispose 

    This works around a situation in which the V8 WASM code calls
into the platform while the Isolate is being disposed.

This goes against the V8 API constract for `v8::Platform`.
In lieu of a proper fix, it should be okay to keep the Isolate
registered; the race condition fixed by 25447d8 cannot
occur for the `NodeMainInstance`’s Isolate, as it is the last
one to exit in any given Node.js process.

This partially reverts 25447d8.

Refs: nodejs#30909
Refs: nodejs#31752
    @addaleax
    addaleax committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    3f7e078 View commit details
    Browse the repository at this point in the history