Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: discard tasks posted to platform TaskRunner during shutdown #31853

Closed
wants to merge 2 commits into from
Closed

src: discard tasks posted to platform TaskRunner during shutdown #31853

wants to merge 2 commits into from

Commits on Feb 18, 2020

  1. src: discard tasks posted to platform TaskRunner during shutdown 

    Discard tasks silently that are posted when the Isolate is being
disposed.

It is not possible to avoid a race condition window between
unregistering the Isolate with the platform and disposing it
in which background tasks and the Isolate deinit steps themselves
may lead to new tasks being posted. The only sensible action
in that case is discarding the tasks.

Fixes: nodejs#31752
Fixes: https://bugs.chromium.org/p/v8/issues/detail?id=10104
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2061548
Refs: nodejs#31795
Refs: nodejs#30909
    @addaleax
    addaleax committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    023ed84 View commit details
    Browse the repository at this point in the history

  2. Revert "src: keep main-thread Isolate attached to platform during Dis… 

    …pose"

This reverts commit e460f8c.

It is no longer necessary after the previous commit, and restores
consistency of the call order between the main thread code,
the other call sites, and the documentation.

Refs: nodejs#31795
    @addaleax
    addaleax committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    06eff80 View commit details
    Browse the repository at this point in the history