Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.10.0 proposal #32027

Merged
merged 91 commits into from
Mar 4, 2020
Merged

v13.10.0 proposal #32027

merged 91 commits into from
Mar 4, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Feb 29, 2020

2020-03-04, Version 13.10.0 (Current), @codebytere

Notable Changes

  • async_hooks
    • introduce async-context API (vdeturckheim) #26540
  • stream
    • support passing generator functions into pipeline() (Robert Nagy) #31223
  • tls
    • expose SSL_export_keying_material (simon) #31814
  • vm
    • implement vm.measureMemory() for per-context memory measurement (Joyee Cheung) #31824

Commits

  • [f71fc9044a] - async_hooks: add store arg in AsyncLocalStorage (Andrey Pechkurov) #31930
  • [6af9e7e0c3] - async_hooks: executionAsyncResource matches in hooks (Gerhard Stoebich) #31821
  • [877ab97286] - (SEMVER-MINOR) async_hooks: introduce async-context API (vdeturckheim) #26540
  • [9a41ced0d1] - build: only lint markdown files that have changed (POSIX-only) (Rich Trott) #31923
  • [ca4407105e] - build: add missing comma in node.gyp (cjihrig) #31959
  • [4dffd0437d] - cli: --perf-prof only works on Linux (Shelley Vohr) #31892
  • [4d05508aa8] - crypto: turn impossible DH errors into assertions (Tobias Nießen) #31934
  • [d0e94fc77e] - crypto: fix ieee-p1363 for createVerify (Tobias Nießen) #31876
  • [fbaab7d854] - deps: openssl: cherry-pick 4dcb150ea30f (Adam Majer) #32002
  • [e6125cd53b] - deps: V8: backport f7771e5b0cc4 (Matheus Marchini) #31957
  • [c27f0d10c4] - deps: update zlib to upstream d7f3ca9 (Sam Roberts) #31800
  • [b30a6981d3] - deps: move zlib maintenance info to guides (Sam Roberts) #31800
  • [cd30dbb0d6] - doc: revise --zero-fill-buffers text in buffer.md (Rich Trott) #32019
  • [166579f84b] - doc: add link to sem-ver info (unknown) #31985
  • [e3258fd148] - doc: update zlib doc (James M Snell) #31665
  • [8516602ba0] - doc: clarify http2.connect authority details (James M Snell) #31828
  • [c5acf0a13b] - doc: updated YAML version representation in readline.md (Rich Trott) #31924
  • [4c6343fdea] - doc: describe how to update zlib (Sam Roberts) #31800
  • [a46839279f] - doc: update releases guide re pushing tags (Myles Borins) #31855
  • [15cc9b0126] - doc: update assert.rejects() docs with a validation function example (Eric Eastwood) #31271
  • [2046652b4e] - doc: fix anchor for ERR_TLS_INVALID_CONTEXT (Tobias Nießen) #31915
  • [091b4bfe2d] - doc: add note about ssh key to releases (Shelley Vohr) #31856
  • [3438937a37] - doc: fix notable changes for v13.9.0 (Shelley Vohr) #31857
  • [672f76d6bd] - doc: reword possessive form of Node.js in adding-new-napi-api.md (Rich Trott) #31748
  • [3eaf37767e] - doc: reword possessive form of Node.js in http.md (Rich Trott) #31748
  • [cb210e6b16] - doc: reword possessive form of Node.js in process.md (Rich Trott) #31748
  • [3969af43b4] - doc: reword possessive form of Node.js in debugger.md (Rich Trott) #31748
  • [f9526057b3] - doc: move gireeshpunathil to TSC emeritus (Gireesh Punathil) #31770
  • [b07175853f] - doc: pronouns for @Fishrock123 (Jeremiah Senkpiel) #31725
  • [7f4d6ee8ea] - doc: move @Fishrock123 to TSC Emeriti (Jeremiah Senkpiel) #31725
  • [b177bba555] - doc: move @Fishrock123 to a previous releaser (Jeremiah Senkpiel) #31725
  • [9e4aad705f] - doc: fix typos in doc/api/https.md (Jeff) #31793
  • [eb2dce8342] - doc: claim ABI version 82 for Electron 10 (Samuel Attard) #31778
  • [db291aaf06] - doc: guide - using valgrind to debug memory leaks (Michael Dawson) #31501
  • [aa16d80c05] - doc,crypto: re-document oaepLabel option (Ben Noordhuis) #31825
  • [9079bb42ea] - http2: make compat finished match http/1 (Robert Nagy) #24347
  • [3bd8feac0c] - meta: move aqrln to emeritus (Rich Trott) #31997
  • [c801045fcd] - meta: move jbergstroem to emeritus (Rich Trott) #31996
  • [ded3890bec] - meta: move maclover7 to Emeritus (Rich Trott) #31994
  • [91ce69a554] - meta: move Glen Keane to Collaborator Emeritus (Rich Trott) #31993
  • [b74c40eda6] - meta: move not-an-aardvark to emeritus (Rich Trott) #31928
  • [61a0d8b6cd] - meta: move julianduque to emeritus (Rich Trott) #31863
  • [94a471a422] - meta: move eljefedelrodeodeljefe to emeritus (Rich Trott) #31735
  • [9e3e6763fa] - module: port source map sort logic from chromium (bcoe) #31927
  • [b9f3bfe6c8] - module: disable conditional exports, self resolve warnings (Guy Bedford) #31845
  • [bbb6cc733c] - module: package "exports" error refinements (Guy Bedford) #31625
  • [6adbfac9b0] - repl: eager-evaluate input in parens (Shelley Vohr) #31943
  • [6a35b0d102] - src: don't run bootstrapper in CreateEnvironment (Shelley Vohr) #31910
  • [3497370d66] - src: move InternalCallbackScope to StartExecution (Shelley Vohr) #31944
  • [f62967c827] - src: enable StreamPipe for generic StreamBases (Anna Henningsen) #31869
  • [776f379124] - src: include large pages source unconditionally (Gabriel Schulhof) #31904
  • [9f68e14052] - src: elevate v8 namespaces (Harshitha KP) #31901
  • [8fa6373e62] - src: allow unique_ptrs with custom deleter in memory tracker (Anna Henningsen) #31870
  • [88ccb444e3] - src: move BaseObject subclass dtors/ctors out of node_crypto.h (Anna Henningsen) #31872
  • [98d262e5f3] - src: inform callback scopes about exceptions in HTTP parser (Anna Henningsen) #31801
  • [57302f866e] - src: prefer 3-argument Array::New() (Anna Henningsen) #31775
  • [8a2b62e4cd] - stream: ensure pipeline always destroys streams (Robert Nagy) #31940
  • [313ecaabe5] - stream: fix broken pipeline error propagation (Robert Nagy) #31835
  • [8ad64b8e53] - (SEMVER-MINOR) stream: support passing generator functions into pipeline() (Robert Nagy) #31223
  • [d0a00711f8] - stream: invoke buffered write callbacks on error (Robert Nagy) #30596
  • [1bca7b6c70] - test: move test-inspector-module to parallel (Rich Trott) #32025
  • [932563473c] - test: improve disable AsyncLocalStorage test (Andrey Pechkurov) #31998
  • [49864d161e] - test: fix flaky test-dns-any.js (Rich Trott) #32017
  • [38494746a6] - test: fix flaky test-gc-net-timeout (Robert Nagy) #31918
  • [b6d33f671a] - test: change test to not be sensitive to buffer send size (Rusty Conover) #31499
  • [cef5502055] - test: remove sequential/test-https-keep-alive-large-write.js (Rusty Conover) #31499
  • [f1e76488a7] - test: validate common property usage (Denys Otrishko) #31933
  • [ab8f060159] - test: fix usage of invalid common properties (Denys Otrishko) #31933
  • [49c959d636] - test: increase timeout in vm-timeout-escape-queuemicrotask (Denys Otrishko) #31966
  • [04eda02d87] - test: add documentation for common.enoughTestCpu (Rich Trott) #31931
  • [918c2b67cc] - test: fix typo in common/index.js (Rich Trott) #31931
  • [f89fb2751b] - test: mark empty udp tests flaky on OS X (Sam Roberts) #31936
  • [e08fef1fda] - test: add secp224k1 check in crypto-dh-stateless (Daniel Bevenius) #31715
  • [4fe9e043ef] - test: remove common.PORT from assorted pummel tests (Rich Trott) #31897
  • [7d5776e119] - test: remove flaky designation for test-net-connect-options-port (Rich Trott) #31841
  • [1933efa62f] - test: remove common.PORT from test-net-write-callbacks.js (Rich Trott) #31839
  • [87e9014764] - test: remove common.PORT from test-net-pause (Rich Trott) #31749
  • [3fbd5ab265] - test: remove common.PORT from test-tls-server-large-request (Rich Trott) #31749
  • [e76ac1d2c9] - test: remove common.PORT from test-net-throttle (Rich Trott) #31749
  • [724bf3105b] - test: remove common.PORT from test-net-timeout (Rich Trott) #31749
  • [60c71dcad2] - test: add known issue test for sync writable callback (James M Snell) #31756
  • [2c0b249098] - tls: reduce memory copying and number of BIO buffer allocations (Rusty Conover) #31499
  • [acb3aff674] - (SEMVER-MINOR) tls: expose SSL_export_keying_material (simon) #31814
  • [f293dcf6de] - tools: add NODE_TEST_NO_INTERNET to the doc builder (Joyee Cheung) #31849
  • [79b1f04b15] - tools: sync gyp code base with node-gyp repo (Michaël Zasso) #30563
  • [f858f2366c] - tools: update lint-md task to lint for possessives of Node.js (Rich Trott) #31862
  • [ae3929e958] - (SEMVER-MINOR) vm: implement vm.measureMemory() for per-context memory measurement (Joyee Cheung) #31824
  • [a86cb0e480] - vm: lazily initialize primordials for vm contexts (Joyee Cheung) #31738
  • [f2389eba99] - worker: emit runtime error on loop creation failure (Harshitha KP) #31621
  • [f87ac90849] - worker: unroll file extension regexp (Anna Henningsen) #31779

mhdawson and others added 30 commits February 27, 2020 08:45
Add doc for using valgrind to debug native
memory leaks.

Started writing this up as part of an effort
in the Diagnostic WG but think it's better
to have it in the core guides and then be referenced
by the docs in the Diagnostic WG repo.

For more details on the Diagnostic WG effort see
nodejs/diagnostics#254 (comment)
This guide is related to `/step3 - using_native_tools.md`

PR-URL: #31501
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This is nicer, because:

1. It reduces overall code size,
2. It’s faster, because `Object::Set()` calls are relatively slow, and
3. It helps avoid invalid `.Check()`/`.FromJust()` calls.

PR-URL: #31775
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
PR-URL: #31778
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Refs: #31662 (comment)

PR-URL: #31779
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #31793
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
I have not done a release in well over a year, maybe even two.

I also don't really plan to do more,
as Node.js releases are very tedious.

PR-URL: #31725
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
It was a good run. Almost 5 years.

I haven't really been involved in the last 3+? months though,
so it's time I call it and 'retire'.

I think it is unlikely that I'll be on the TSC again,
as node is unfortunately becoming increasingly
disinteresting (& frustrating) to me.

(So long and thanks for all the fish!)

PR-URL: #31725
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
might as well while I'm at it

feels a bit weird being the first person on this list
with '/they' but I guess someone's gota do it

PR-URL: #31725
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #31770
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
If the write callbacks are invoked synchronously with an
error, onwriteError would cause the error event to be
emitted synchronously, making it impossible to attach
an error handler after the call that triggered it.

PR-URL: #31756
Refs: nodejs/quic@b0d469c
Refs: nodejs/quic#341
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Throughout the docs, we sometimes write the possessive of _Node.js_ as
_Node.js'_ and other times as _Node.js's_. The former conforms with some
generally accepted style guides (e.g., Associated Press Stylebook) while
the latter complies with others (e.g., Chicago Manual of Style).

Since there is no clear authoritative answer as to which form is
correct, and since (at least to me) both are visually jarring and
sometimes cause a pause to understand, I'd like to reword things to
eliminate the possessive form where possible.

This is one of those examples.

PR-URL: #31748
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Throughout the docs, we sometimes write the possessive of _Node.js_ as
_Node.js'_ and other times as _Node.js's_. The former conforms with some
generally accepted style guides (e.g., Associated Press Stylebook) while
the latter complies with others (e.g., Chicago Manual of Style).

Since there is no clear authoritative answer as to which form is
correct, and since (at least to me) both are visually jarring and
sometimes cause a pause to understand, I'd like to reword things to
eliminate the possessive form where possible.

This is one of those examples.

PR-URL: #31748
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Throughout the docs, we sometimes write the possessive of _Node.js_ as
_Node.js'_ and other times as _Node.js's_. The former conforms with some
generally accepted style guides (e.g., Associated Press Stylebook) while
the latter complies with others (e.g., Chicago Manual of Style).

Since there is no clear authoritative answer as to which form is
correct, and since (at least to me) both are visually jarring and
sometimes cause a pause to understand, I'd like to reword things to
eliminate the possessive form where possible.

This is one of those examples.

PR-URL: #31748
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Throughout the docs, we sometimes write the possessive of _Node.js_ as
_Node.js'_ and other times as _Node.js's_. The former conforms with some
generally accepted style guides (e.g., Associated Press Stylebook) while
the latter complies with others (e.g., Chicago Manual of Style).

Since there is no clear authoritative answer as to which form is
correct, and since (at least to me) both are visually jarring and
sometimes cause a pause to understand, I'd like to reword things to
eliminate the possessive form where possible.

This is one of those examples.

PR-URL: #31748
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Refs: 4aca277
Refs: #30236
Fixes: #31796

PR-URL: #31801
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Switch test-net-timeout from common.PORT to a port assigned by the
operating system.

PR-URL: #31749
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Switch test-net-throttle from common.PORT to a port assigned by the
operating system.

PR-URL: #31749
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Switch test-tls-server-large-request from common.PORT to a port assigned
by the operating system.

PR-URL: #31749
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Switch test-net-pause from common.PORT to a port assigned by the
operating system.

PR-URL: #31749
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
finished should true directly after end().

PR-URL: #24347
Refs: #24743
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #31857
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
eljefedelrodeodeljefe confirmed in email that moving to emeritus was
fine at this time.

PR-URL: #31735
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Lazily initialize primordials when cross-context support for
builtins is needed to fix the performance regression in context
creation.

PR-URL: #31738
Fixes: #29842
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Instead of hard asserting throw a runtime error,
that is more consumable.

Fixes: #31614

PR-URL: #31621
Reviewed-By: Anna Henningsen <[email protected]>
Switch test-net-write-callbacks.js from common.PORT to a port assigned
by the operating system.

PR-URL: #31839
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Closes: #23207

PR-URL: #31841
Fixes: #23207
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Add a markdown lint rule to prohibit "Node.js'" and "Node.js's".
Instead, of "Node.js' module system", use "the Node.js module system".

Refs: #31748 (comment)

PR-URL: #31862
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #31856
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #30563
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Trott and others added 4 commits March 3, 2020 09:03
There was an unclear sentence fragment that needed fixing, so I edited
the entire paragraph for clarity. I also removed irrelevant information
about behavior before Node.js 8.0.0. That version of Node.js is no
longer supported and these docs will never apply to 8.0.0. (At the time
of this writing, 10.x is the oldest supported line, and so changes to
the docs will never be backported farther than the 10.x docs.)

PR-URL: #32019
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #31998
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: James M Snell <[email protected]>
OpenSSL 1.1.1d does not ship with getrandom syscall being
predefined on all architectures. So when NodeJS is run with glibc
prior to 2.25, where getentropy is unavailable, and the getrandom
syscall is unknown, it will fail. PPC64LE or s390 are affected
by lack of this definition.

Original commit message.

    commit 4dcb150ea30f9bbfa7946e6b39c30a86aca5ed02
    Author: Kurt Roeckx <[email protected]>
    Date:   Sat Sep 28 14:59:32 2019 +0200

      Add defines for __NR_getrandom for all Linux architectures

      Fixes: openssl/openssl#10015

      Reviewed-by: Bernd Edlinger <[email protected]>
      GH: openssl/openssl#10044

Fixes: #31671
PR-URL: #32002
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
test-inspector-module is very fast and seems to be runnable at the same
time as other tests. Move from sequential directory to parallel.

PR-URL: #32025
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
codebytere added a commit that referenced this pull request Mar 3, 2020
Notable changes:

* async_hooks
  * introduce async-context API (vdeturckheim) #26540
* stream
  * support passing generator functions into pipeline() (Robert Nagy) #31223
* tls
  * expose SSL\_export\_keying\_material (simon) #31814
* vm
  * implement vm.measureMemory() for per-context memory measurement (Joyee Cheung) #31824

PR-URL: #32027
@nodejs nodejs deleted a comment from nodejs-github-bot Mar 3, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 3, 2020

@codebytere
Copy link
Member Author

Removing 5d79164 owing to #31981 (comment)

codebytere added a commit that referenced this pull request Mar 3, 2020
Notable changes:

* async_hooks
  * introduce async-context API (vdeturckheim) #26540
* stream
  * support passing generator functions into pipeline() (Robert Nagy) #31223
* tls
  * expose SSL\_export\_keying\_material (simon) #31814
* vm
  * implement vm.measureMemory() for per-context memory measurement (Joyee Cheung) #31824

PR-URL: #32027
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs nodejs deleted a comment from nodejs-github-bot Mar 3, 2020
@codebytere
Copy link
Member Author

codebytere commented Mar 3, 2020

@nodejs/releasers still seeing a consistent failure on macOS 10.15 - at this stage I think we should hold and try tomorrow. Failures are here: https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1015/32317/console

sequential/test-timers-blocking-callback in particular does not seem to be flaky unless i'm missing some context.

v13.9.0 comparison: https://ci.nodejs.org/job/node-test-pull-request/29527/

Notable changes:

* async_hooks
  * introduce async-context API (vdeturckheim) #26540
* stream
  * support passing generator functions into pipeline() (Robert Nagy) #31223
* tls
  * expose SSL\_export\_keying\_material (simon) #31814
* vm
  * implement vm.measureMemory() for per-context memory measurement (Joyee Cheung) #31824

PR-URL: #32027
@richardlau
Copy link
Member

@nodejs/releasers still seeing a consistent failure on macOS 10.15 - at this stage I think we should hold and try tomorrow. Failures are here: https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1015/32317/console

sequential/test-timers-blocking-callback in particular does not seem to be flaky unless i'm missing some context.

v13.9.0 comparison: https://ci.nodejs.org/job/node-test-pull-request/29527/

FWIW we've only just recently added macOS 10.15 to the CI. cc @AshCripps

@AshCripps
Copy link
Member

The dgram tests are marked flaky on osx because of a regression in macos10.15.

not sure about the sequential/test-timers-blocking-callback one though

@nodejs-github-bot
Copy link
Collaborator

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codebytere codebytere merged commit f6ffdc2 into v13.x Mar 4, 2020
codebytere added a commit that referenced this pull request Mar 4, 2020
codebytere added a commit that referenced this pull request Mar 4, 2020
Notable changes:

* async_hooks
  * introduce async-context API (vdeturckheim) #26540
* stream
  * support passing generator functions into pipeline() (Robert Nagy) #31223
* tls
  * expose SSL\_export\_keying\_material (simon) #31814
* vm
  * implement vm.measureMemory() for per-context memory measurement (Joyee Cheung) #31824

PR-URL: #32027
codebytere added a commit to nodejs/nodejs.org that referenced this pull request Mar 4, 2020
codebytere added a commit to nodejs/nodejs.org that referenced this pull request Mar 4, 2020
@sam-github sam-github deleted the v13.10.0-proposal branch March 20, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.