[v13.x backport] stream: improve writable.write() performance #32169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
stream
ronag
force-pushed
the
backport-31624-to-v13.x
branch
from
dffb531
to
b2c65e1
Compare
ronag
force-pushed
the
backport-31624-to-v13.x
branch
2 times, most recently
from
a60ec3c
to
7e745f9
Compare
ronag
force-pushed
the
backport-31624-to-v13.x
branch
from
7e745f9
to
fa39531
Compare
7 tasks
PR-URL: nodejs#31624 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Backport-PR-URL: nodejs#32169
ronag
force-pushed
the
backport-31624-to-v13.x
branch
from
fa39531
to
1d88182
Compare
|
If you wonder about the difference with the original commit. This depends on some other commit I can't find and haven't been backported (possibly semver-major due to other changes in that PR?). Though I think it should be fine like this. |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 10, 2020
Backport-PR-URL: #32169 PR-URL: #31624 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
landed in 1e05ddf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #31624
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes