-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: linting for buffer-free-callback test #3230
Conversation
Test added in d1f2404 does not pass linting rule added in 3de353b. Fixed in this commit. `common` module required in all tests except those that intentionally leak variables. Fixes: nodejs#3229
/cc @indutny This minor change to your test look good to you? |
LGTM |
@Trott I didn't see any errors when committing it. Are you sure that it is required for addons? |
@indutny Yes, I'm postive.
|
Ok, LGTM then. |
Shouldn't it go to other addons too? |
Yes, all the previously existing addon tests that didn't use |
Because this change is so small and CI will fail until it lands, I'm going to go ahead and land it right away. |
Test added in d1f2404 does not pass linting rule added in 3de353b. Fixed in this commit. `common` module required in all tests except those that intentionally leak variables. PR-URL: #3230 Fixes: #3229 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Landed in 6f63a4a |
Test added in d1f2404 does not pass linting rule added in 3de353b. Fixed in this commit. `common` module required in all tests except those that intentionally leak variables. PR-URL: #3230 Fixes: #3229 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Test added in d1f2404 does not pass linting rule added in 3de353b.
Fixed in this commit.
common
module required in all tests exceptthose that intentionally leak variables.
Fixes: #3229