Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: unflake async-hooks/test-statwatcher #32484

Closed
wants to merge 1 commit into from
Closed

test: unflake async-hooks/test-statwatcher #32484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/async-hooks/async-hooks.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ prefix async-hooks
[true] # This section applies to all platforms

[$system==win32]
# https://github.com/nodejs/node/issues/29852
test-statwatcher: PASS,FLAKY

[$system==linux]

Expand Down
4 changes: 0 additions & 4 deletions test/async-hooks/test-statwatcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ w1.on('change', common.mustCallAtLeast((curr, prev) => {
// Wait until we get the write above.
if (prev.size !== 0 || curr.size !== 5)
return;
// Remove listeners to make w1HookCount final
w1.removeAllListeners('change');

setImmediate(() => {
checkInvocations(statwatcher1,
Expand All @@ -81,8 +79,6 @@ w1.on('change', common.mustCallAtLeast((curr, prev) => {
// Wait until we get the write above.
if (prev.size !== 0 || curr.size !== 5)
return;
// Remove listeners to make w2HookCount final
w2.removeAllListeners('change');

setImmediate(() => {
checkInvocations(statwatcher1,
Expand Down