doc: clarify requireManualDestroy option
#32514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
addaleax
approved these changes
Mar 27, 2020
jasnell
approved these changes
Mar 27, 2020
lpinca
approved these changes
Mar 28, 2020
vdeturckheim
approved these changes
Apr 2, 2020
addaleax
pushed a commit
that referenced
this pull request
Apr 2, 2020
Fixes: #32409 PR-URL: #32514 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
|
Landed in 7947811 |
4 tasks
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
Fixes: #32409 PR-URL: #32514 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
Fixes: #32409 PR-URL: #32514 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Fixes: #32409 PR-URL: #32514 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #32409
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes