test: test sys rather than common

[Trott]

test-sys.js seems to test common.inspect() (which is test-specific code) and not sys (which, although deprecated, should still be tested).

This seems like it was introduced in 9fd5e3c which is a pretty big commit with lots of probable find/replace.

This commit changes it to test sys which is what the file name implies it should be doing.

[targos]

Since sys is just the same as util, can't we just make sure that all the tests in this file are done in the test-util* files and then just remove everything and do assert.strictEqual(require('sys'), require('util')) ?

[evanlucas]

I'm with @targos on this. A lot of the tests are duplicated anyways

[Trott]

OK, done, all sys tests moved to util and sys test replaced with a strictEqual() check that sys and util are the same thing.

[evanlucas]

LGTM

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/466/

Assuming CI is green, I'll land this in the next few hours unless someone objects.

[Trott]

Well, that was embarrassing. Let's try this again. CI: https://ci.nodejs.org/job/node-test-pull-request/467/

[Trott]

@evanlucas Very minor change to correct a test I botched. Still LGTY? /cc @targos

[evanlucas]

yep, LGTM

[Trott]

Landed in ead5cd9

[jasnell]

Landed in v4.x in 5ca4f6f