Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: copy addons .gitignore to test/abort/ #32624

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Apr 2, 2020

cp test/addons/.gitignore test/abort/.gitignore, because the new
addon test in there leaves a build/ folder lying around and somebody
is bound to use git add . earlier or later.

Refs: #31740

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

`cp test/addons/.gitignore test/abort/.gitignore`, because the new
addon test in there leaves a build/ folder lying around and somebody
is bound to use `git add .` earlier or later.

Refs: nodejs#31740
@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 2, 2020
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 2, 2020
@addaleax
Copy link
Member Author

addaleax commented Apr 2, 2020

Please 👍 this comment to approve fast-tracking

@richardlau
Copy link
Member

Fwiw I don’t think that new test will be run on the CI because the test configuration won’t find it. But that’s one for a follow up PR.

@richardlau
Copy link
Member

Fwiw I don’t think that new test will be run on the CI because the test configuration won’t find it. But that’s one for a follow up PR.

Yeah the new test wasn't being run and AFAICT it's broken: #31740 (comment)

@addaleax addaleax removed the fast-track PRs that do not need to wait for 48 hours to land. label Apr 2, 2020
@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 3, 2020
@richardlau
Copy link
Member

Fwiw I don’t think that new test will be run on the CI because the test configuration won’t find it. But that’s one for a follow up PR.

Yeah the new test wasn't being run and AFAICT it's broken: #31740 (comment)

Believe I've fixed up the test: #32626
I almost accidentally added the build directory to that PR, so 💯 👍 to fast tracking this one.

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Apr 5, 2020
@addaleax
Copy link
Member Author

addaleax commented Apr 5, 2020

Landed in cf659c8

addaleax added a commit that referenced this pull request Apr 5, 2020
`cp test/addons/.gitignore test/abort/.gitignore`, because the new
addon test in there leaves a build/ folder lying around and somebody
is bound to use `git add .` earlier or later.

Refs: #31740

PR-URL: #32624
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax closed this Apr 5, 2020
@addaleax addaleax deleted the abort-gitignore branch April 5, 2020 19:13
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
`cp test/addons/.gitignore test/abort/.gitignore`, because the new
addon test in there leaves a build/ folder lying around and somebody
is bound to use `git add .` earlier or later.

Refs: #31740

PR-URL: #32624
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
`cp test/addons/.gitignore test/abort/.gitignore`, because the new
addon test in there leaves a build/ folder lying around and somebody
is bound to use `git add .` earlier or later.

Refs: #31740

PR-URL: #32624
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
`cp test/addons/.gitignore test/abort/.gitignore`, because the new
addon test in there leaves a build/ folder lying around and somebody
is bound to use `git add .` earlier or later.

Refs: #31740

PR-URL: #32624
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants