Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,win: Replacement of unsupported versions of Windows runtime exit. #33108

Closed
wants to merge 9 commits into from
Closed

src,win: Replacement of unsupported versions of Windows runtime exit. #33108

wants to merge 9 commits into from
+23 −12

Commits on Apr 28, 2020

  1. src,win,msi: changed exit on unsupported version to extended warning … 

    …of limited support
    Samuel J Voeller committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    111226e View commit details
    Browse the repository at this point in the history

  2. src: fix spacing for deprecation banner

    Samuel J Voeller committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    22e91a0 View commit details
    Browse the repository at this point in the history

  3. fix: multiline comment for C++ linter

    Samuel J Voeller committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    7869c2f View commit details
    Browse the repository at this point in the history

  4. msi: adjust message for official support

    Samuel J Voeller committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    6ee8998 View commit details
    Browse the repository at this point in the history

  5. src,win: relocate unsupported os warning to node.cc to allow --no-war… 

    …nings flag
    Samuel J Voeller committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    55bcf51 View commit details
    Browse the repository at this point in the history

  6. fix: remove the two whitespace linting error...

    Samuel J Voeller committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    f6c4c8b View commit details
    Browse the repository at this point in the history

  7. comment: remove unnecessary comment for windows 

    Co-Authored-By: James M Snell <[email protected]>
    @xCykrix @jasnell
    xCykrix and jasnell committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    a01b275 View commit details
    Browse the repository at this point in the history

  8. comment: corrected grammar mistake 

    Co-Authored-By: Bartosz Sosnowski <[email protected]>
    @xCykrix @bzoz
    xCykrix and bzoz committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    63e62c8 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. Update tools/msvs/msi/product.wxs 

    msi: grammar correction

Co-Authored-By: Rich Trott <[email protected]>
    @xCykrix @Trott
    xCykrix and Trott committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    329279f View commit details
    Browse the repository at this point in the history