Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reword explanation #33149

Closed
wants to merge 4 commits into from
Closed

reword explanation #33149

wants to merge 4 commits into from

Conversation

dheeraj-br
Copy link

@dheeraj-br dheeraj-br commented Apr 29, 2020

Rewording of emitter.removeListener(eventName, listener) explanation to make it easier to understand

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Rewording of emitter.removeListener(eventName, listener) explanation to make it easier to understand
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Apr 29, 2020
doc/api/events.md Outdated Show resolved Hide resolved
Co-authored-by: James M Snell <[email protected]>
doc/api/events.md Outdated Show resolved Hide resolved
doc/api/events.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented May 1, 2020

Hi @dheeraj-br! Welcome, and thanks for the pull request! Documentation changes can attract a lot of comments, so thank you in advance for your patience with the process!

@Trott
Copy link
Member

Trott commented May 1, 2020

@nodejs/documentation @nodejs/events I'm having a hard time telling if this change makes the explanation clearer or not. Thoughts?

dheeraj-br and others added 2 commits May 3, 2020 06:40
Co-authored-by: Rich Trott <[email protected]>
Co-authored-by: Rich Trott <[email protected]>
@rexagod
Copy link
Member

rexagod commented May 3, 2020

-1. I personally think the explanation is okay in it's specificity and is good as is.

@dheeraj-br dheeraj-br closed this May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants