-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reword explanation #33149
Closed
Closed
reword explanation #33149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewording of emitter.removeListener(eventName, listener) explanation to make it easier to understand
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
events
Issues and PRs related to the events subsystem / EventEmitter.
labels
Apr 29, 2020
jasnell
reviewed
Apr 29, 2020
Co-authored-by: James M Snell <[email protected]>
Trott
reviewed
May 1, 2020
Trott
reviewed
May 1, 2020
Hi @dheeraj-br! Welcome, and thanks for the pull request! Documentation changes can attract a lot of comments, so thank you in advance for your patience with the process! |
@nodejs/documentation @nodejs/events I'm having a hard time telling if this change makes the explanation clearer or not. Thoughts? |
Co-authored-by: Rich Trott <[email protected]>
Co-authored-by: Rich Trott <[email protected]>
-1. I personally think the explanation is okay in it's specificity and is good as is. |
This was referenced Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewording of
emitter.removeListener(eventName, listener)
explanation to make it easier to understandChecklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes