events: combined event target fixes #34015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
the
eventtarget
nodejs-github-bot
added
the
events
This comment has been minimized.
This comment has been minimized.
Remove support for multiple arguments (which don't actually work for EventTarget). Use our EventTarget implementation rather than a mock. Refactor `once` code in preparation of `on` using shared code for supporting `on` with `EventTarget`s. Support EventTarget in the `events.on` static method
On the web, dispatchEvent is finicky about its `this` value. An exception is thrown for `this` values which are not an EventTarget.
Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: nodejs#33613 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Co-authored-by: Benjamin Gruenbaum <[email protected]>
Co-authored-by: Benjamin Gruenbaum <[email protected]>
jasnell
force-pushed
the
eventtarget-fixups
branch
from
532379f
to
65af6f1
Compare
This was referenced Jun 22, 2020
lundibundi
approved these changes
Jun 22, 2020
jasnell
added
the
author ready
29 tasks
benjamingr
approved these changes
Jun 23, 2020
|
Since everything here is already approved in other PRs I think this can/should be fast tracked |
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
Co-authored-by: Benjamin Gruenbaum <[email protected]> PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
Co-authored-by: Benjamin Gruenbaum <[email protected]> PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
Fixes: #33782 PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Remove support for multiple arguments (which don't actually work for EventTarget). Use our EventTarget implementation rather than a mock. Refactor `once` code in preparation of `on` using shared code for supporting `on` with `EventTarget`s. Support EventTarget in the `events.on` static method PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
On the web, dispatchEvent is finicky about its `this` value. An exception is thrown for `this` values which are not an EventTarget. PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: #33613 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Co-authored-by: Benjamin Gruenbaum <[email protected]> PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Co-authored-by: Benjamin Gruenbaum <[email protected]> PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Fixes: #33782 PR-URL: #34015 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines the following separate PRs, with fixups, to make them easier to land (landing them one at a time was starting to get extremely painful)
onEventTarget support + once compliance #33659/cc @benjamingr, @mscdex, @lundibundi, @Zirak
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes