Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: add N-API to codeowners coverage #34039

Closed
wants to merge 4 commits into from
Closed

meta: add N-API to codeowners coverage #34039

wants to merge 4 commits into from

Commits on Jun 24, 2020

  1. meta: add N-API to codeowners coverage 

    We have this guidance for contributing to N-API:
https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md

It makes sense to have one of the N-API team sign off on commits
that changes N-API

Signed-off-by: Michael Dawson <[email protected]>
    @mhdawson
    mhdawson committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    d66b000 View commit details
    Browse the repository at this point in the history

  2. squash: address comments

    @mhdawson
    mhdawson authored Jun 24, 2020
    Configuration menu
    Copy the full SHA
    30897f3 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. Update .github/CODEOWNERS 

    Co-authored-by: Richard Lau <[email protected]>
    @mhdawson @richardlau
    mhdawson and richardlau authored Jul 2, 2020
    Configuration menu
    Copy the full SHA
    0ab5c01 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. accept comments 

    Co-authored-by: James M Snell <[email protected]>
    @mhdawson @jasnell
    mhdawson and jasnell authored Jul 3, 2020
    Configuration menu
    Copy the full SHA
    c6e2806 View commit details
    Browse the repository at this point in the history