-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
worker: make MessagePort inherit from EventTarget #34057
Closed
Closed
Commits on Jul 20, 2020
-
This test has not been working correctly since at least a555be2. Since it tests internals, any replacement test might become invalid in a similar way.
Configuration menu - View commit details
-
Copy full SHA for 11a940e - Browse repository at this point
Copy the full SHA 11a940eView commit details -
events: expand NodeEventTarget functionality
Enable `NodeEventTarget` as a base class for `MessagePort`, by enabling special processing of events for Node.js listeners, and removing implicit constructors/private properties so that classes can be made subclasses of `NodeEventTarget` after they are created.
Configuration menu - View commit details
-
Copy full SHA for 0b2cd67 - Browse repository at this point
Copy the full SHA 0b2cd67View commit details -
test: fixup worker + source map test
The messaging code uses `Object.defineProperty()`, which accesses `value` on `Object.prototype` by default, so some calls to the getter here would actually be expected. Instead, make the list of accessed properties more specific to the tested source map code to avoid flakiness. Refs: https://twitter.com/addaleax/status/1276289101671608320
Configuration menu - View commit details
-
Copy full SHA for 37fa701 - Browse repository at this point
Copy the full SHA 37fa701View commit details -
worker: make MessagePort inherit from EventTarget
Use `NodeEventTarget` to provide a mixed `EventEmitter`/`EventTarget` API interface.
Configuration menu - View commit details
-
Copy full SHA for 6b1926f - Browse repository at this point
Copy the full SHA 6b1926fView commit details
Commits on Jul 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c9aabd6 - Browse repository at this point
Copy the full SHA c9aabd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a61bd04 - Browse repository at this point
Copy the full SHA a61bd04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 644932c - Browse repository at this point
Copy the full SHA 644932cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cb1db7 - Browse repository at this point
Copy the full SHA 7cb1db7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.