Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add regression test for C++-created Buffer transfer #34140

Closed

Conversation

addaleax
Copy link
Member

Add a test for a regression that occurs when transferring some
Buffer objects that were created from C++ to a parent thread.

Fixes: #34126

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Add a test for a regression that occurs when transferring some
`Buffer` objects that were created from C++ to a parent thread.

Fixes: nodejs#34126
@addaleax addaleax force-pushed the worker-transfer-buffer-from-crypto branch from a2f8b87 to 0239467 Compare June 30, 2020 18:21
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 30, 2020
@nodejs-github-bot
Copy link
Collaborator

@addaleax
Copy link
Member Author

addaleax commented Jul 7, 2020

Landed in cb67be7

addaleax added a commit that referenced this pull request Jul 7, 2020
Add a test for a regression that occurs when transferring some
`Buffer` objects that were created from C++ to a parent thread.

Fixes: #34126

PR-URL: #34140
Reviewed-By: Gerhard Stöbich <[email protected]>
@addaleax addaleax closed this Jul 7, 2020
@addaleax addaleax deleted the worker-transfer-buffer-from-crypto branch July 7, 2020 21:42
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
Add a test for a regression that occurs when transferring some
`Buffer` objects that were created from C++ to a parent thread.

Fixes: #34126

PR-URL: #34140
Reviewed-By: Gerhard Stöbich <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
Add a test for a regression that occurs when transferring some
`Buffer` objects that were created from C++ to a parent thread.

Fixes: #34126

PR-URL: #34140
Reviewed-By: Gerhard Stöbich <[email protected]>
addaleax added a commit that referenced this pull request Sep 22, 2020
Add a test for a regression that occurs when transferring some
`Buffer` objects that were created from C++ to a parent thread.

Fixes: #34126

PR-URL: #34140
Reviewed-By: Gerhard Stöbich <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEGFAULT on Node Fermium
3 participants