-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quic: additional quic refactors/cleanups #34160
Closed
Closed
Commits on Jul 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 76f941b - Browse repository at this point
Copy the full SHA 76f941bView commit details -
quic: refactor native object flags for better readability
Use is_* and set_* pattern for native object flags to improve readability in the code.
Configuration menu - View commit details
-
Copy full SHA for 8a702bd - Browse repository at this point
Copy the full SHA 8a702bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 790eac1 - Browse repository at this point
Copy the full SHA 790eac1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a545951 - Browse repository at this point
Copy the full SHA a545951View commit details
Commits on Jul 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b78df93 - Browse repository at this point
Copy the full SHA b78df93View commit details -
quic: remove onSessionDestroy callback
The QuicSession can be destroyed during garbage collection and the onSessionDestroy callback was happening in the destructor.
Configuration menu - View commit details
-
Copy full SHA for d90c2e7 - Browse repository at this point
Copy the full SHA d90c2e7View commit details -
Because of the timing of qlog events emitted by ngtcp2, it becomes difficult to handle those as events on the QuicSession object because the final qlog entry is not emitted until the ngtcp2_conn is freed, which can occur when the object is being garbage collected (meaning, we a: can't call out to javascript and b: don't have an object we can use to emit the event). This refactors it into a QLogStream object that allows the qlog data to be piped out using a separate Readable stream.
Configuration menu - View commit details
-
Copy full SHA for 676e89f - Browse repository at this point
Copy the full SHA 676e89fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1bbb55 - Browse repository at this point
Copy the full SHA d1bbb55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ee492e - Browse repository at this point
Copy the full SHA 5ee492eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d50bd7d - Browse repository at this point
Copy the full SHA d50bd7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9e78fb - Browse repository at this point
Copy the full SHA c9e78fbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.