Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: additional quic refactors/cleanups #34160

Closed
wants to merge 11 commits into from

Commits on Jul 1, 2020

  1. Configuration menu
    Copy the full SHA
    76f941b View commit details
    Browse the repository at this point in the history
  2. quic: refactor native object flags for better readability

    Use is_* and set_* pattern for native object flags to improve
    readability in the code.
    jasnell committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    8a702bd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    790eac1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a545951 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. Configuration menu
    Copy the full SHA
    b78df93 View commit details
    Browse the repository at this point in the history
  2. quic: remove onSessionDestroy callback

    The QuicSession can be destroyed during garbage collection and
    the onSessionDestroy callback was happening in the destructor.
    jasnell committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    d90c2e7 View commit details
    Browse the repository at this point in the history
  3. quic: refactor qlog handling

    Because of the timing of qlog events emitted by ngtcp2, it
    becomes difficult to handle those as events on the QuicSession
    object because the final qlog entry is not emitted until the
    ngtcp2_conn is freed, which can occur when the object is being
    garbage collected (meaning, we a: can't call out to javascript
    and b: don't have an object we can use to emit the event).
    
    This refactors it into a QLogStream object that allows the
    qlog data to be piped out using a separate Readable stream.
    jasnell committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    676e89f View commit details
    Browse the repository at this point in the history
  4. quic: fixup lint issues

    jasnell committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    d1bbb55 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5ee492e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d50bd7d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c9e78fb View commit details
    Browse the repository at this point in the history