Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add issue ref for known_issues test #34267

Merged
merged 0 commits into from
Jul 12, 2020
Merged

test: add issue ref for known_issues test #34267

merged 0 commits into from
Jul 12, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 9, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 9, 2020
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 9, 2020
@jasnell
Copy link
Member

jasnell commented Jul 9, 2020

👍 to fast-track

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32294/

@Trott
Copy link
Member Author

Trott commented Jul 12, 2020

Landed in a98426a

@Trott Trott closed this Jul 12, 2020
@Trott Trott merged commit a98426a into nodejs:master Jul 12, 2020
@Trott Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Jul 12, 2020
@Trott Trott deleted the add-url branch July 12, 2020 03:54
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
@Trott @MylesBorins
test: add issue ref for known_issues test
da22ad9 
PR-URL: #34267
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
@Trott @MylesBorins
test: add issue ref for known_issues test
1aad61e 
PR-URL: #34267
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: add issue ref for known_issues test
8045d6e 
PR-URL: #34267
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @jasnell @nodejs-github-bot @tniessen @addaleax