cluster: make kill to be just process.kill #34312

baradm100 · 2020-07-11T13:47:07Z

Make Worker.prototype.kill to be just process.kill without preforming graceful disconnect beforehand.

Issue

#33715

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

README.md

Trott · 2020-07-11T15:11:13Z

cc @nodejs/cluster

This seems like a semver-major change to me. Is it?

test/parallel/test-cluster-worker-kill-signal.js

baradm100 · 2020-07-11T16:02:01Z

Followed the #33715 issue:

make kill NOT do a disconnect, just be childprocess.kill

discussion: Cluster worker.kill(signal) does not pass the signal parameter node-v0.x-archive#6042

kill rename:

cluster: Rename destroy() to kill(signal=SIGTERM) node-v0.x-archive#4908

cluster: rename worker.destroy() to worker.kill() again node-v0.x-archive#4133

discussion for rename: cluster: rename worker.destroy() to worker.kill() again node-v0.x-archive#4133 (comment)

worker.kill(SIG)... SIG is not normally received

cluster/child_process exit event does not pass signal if child is killed node-v0.x-archive#5832 (comment)

Cluster worker.kill(signal) does not pass the signal parameter node-v0.x-archive#6042

Cluster API: worker process can't get 'SIGTERM' signal when being killed node-v0.x-archive#5766

test/parallel/test-cluster-worker-kill-signal.js

baradm100 · 2020-07-11T16:59:29Z

@mscdex : Due to how common.mustCall is working I can't use it on process.on('exit') making it uncertain if the assertion actually happened, therefor I'm moving the assertion to cluster.on('exit') with common.mustCall 😁

bnoordhuis

I'll add the semver-major label. There are at least two observable changes after calling worker.destroy():

value of worker.exitedAfterDisconnect (currently true, false with this PR)
'disconnect' event (currently emitted, not so with this PR)

Both look like they might cause ecosystem fallout. I'd err on the side of caution and not merge this.

doc/api/cluster.md

test/parallel/test-cluster-worker-kill-signal.js

baradm100 · 2020-07-12T11:34:28Z

I'll add the semver-major label. There are at least two observable changes after calling worker.destroy():

value of worker.exitedAfterDisconnect (currently true, false with this PR)

'disconnect' event (currently emitted, not so with this PR)

Both look like they might cause ecosystem fallout. I'd err on the side of caution and not merge this.

Thanks @bnoordhuis for the review and comments.
This change is changing the destroy behaviour and need to be thoroughly reviewed and widely agreed before merging.
The current behaviour is causing the worker process to be killed by the master and not sending the given signo (due to gracefully disconnecting before preforming the .kill).
In this PR the destroy behaviour is to just preform process.kill

In the #33715 issue (composed by @sam-github) the behaviour change was requested.
If the change is too drastic we should close this PR.

baradm100 · 2020-07-12T13:32:20Z

Another way is to keep the destroy behaviour and just change the Worker.prototype.kill behaviour (currently the kill is just an alias to the destroy function).

bnoordhuis · 2020-07-13T15:47:07Z

@nodejs/cluster This needs your input.

PoojaDurgad · 2021-01-21T09:30:27Z

@baradm100 - need a rebase to resolve git conflicts

baradm100 · 2021-01-22T09:05:06Z

@baradm100 - need a rebase to resolve git conflicts

@PoojaDurgad - Done 😁

RaisinTen · 2021-01-22T13:27:27Z

@baradm100 can you please get rid of the merge commits and perform a rebase instead? Merge commits break our tooling.

baradm100 · 2021-01-22T14:59:46Z

@baradm100 can you please get rid of the merge commits and perform a rebase instead? Merge commits break our tooling.

@RaisinTen - Done

nodejs-github-bot · 2021-01-22T15:05:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35673/

doc/api/cluster.md

BridgeAR · 2021-03-18T16:15:39Z

@sam-github PTAL

baradm100 · 2021-05-14T14:01:49Z

Any update regarding the PR? Do we have an ETA to merge it?

aduh95 · 2021-09-15T15:40:56Z

Ping @nodejs/cluster @nodejs/tsc for reviews.

Make `Worker.prototype.kill` to be just process.kill without preforming graceful disconnect beforehand. Refs: nodejs#33715

@bnoordhuis

as suggested by @bnoordhuis

baradm100 · 2022-02-04T13:49:01Z

Thanks @aduh95!
The branch was rebased, it's ready for the CI.

nodejs-github-bot · 2022-02-04T14:26:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42346/

nodejs-github-bot · 2022-02-04T17:51:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42349/

aduh95 · 2022-02-04T23:15:54Z

Landed in 38007df, thanks for the contribution 🎉

Notable Changes: Deprecations and Removals: - (SEMVER-MAJOR) fs: runtime deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) (#42607) - (SEMVER-MAJOR) dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion (Antoine du Hamel) (#41431) - (SEMVER-MAJOR) process: runtime deprecate multipleResolves (Benjamin Gruenbaum) (#41896) - (SEMVER-MAJOR) stream: remove thenable support (Robert Nagy) (#40773) - (SEMVER-MAJOR) tls: move tls.parseCertString to end-of-life (Tobias Nießen) (#41479) fetch (experimental): An experimental fetch API is available on the global scope by default. The implementation is based upon https://undici.nodejs.org/#/, an HTTP/1.1 client written for Node.js by contributors to the project. Through this addition, the following globals are made available: `fetch` , `FormData`, `Headers`, `Request`, `Response`. Disable this API with the `--no-experimental-fetch` command-line flag. Contributed by Michaël Zasso in #41811. HTTP Timeouts: `server.headersTimeout`, which limits the amount of time the parser will wait to receive the complete HTTP headers, is now set to `60000` (60 seconds) by default. `server.requestTimeout`, which sets the timeout value in milliseconds for receiving the entire request from the client, is now set to `300000` (5 minutes) by default. If these timeouts expire, the server responds with status 408 without forwarding the request to the request listener and then closes the connection. Both timeouts must be set to a non-zero value to protect against potential Denial-of-Service attacks in case the server is deployed without a reverse proxy in front. Contributed by Paolo Insogna in #41263. Test Runner module (experimental): The `node:test` module facilitates the creation of JavaScript tests that report results in TAP format. This module is only available under the `node:` scheme. Contributed by Colin Ihrig in #42325. Toolchain and Compiler Upgrades: - Prebuilt binaries for Linux are now built on Red Hat Enterprise Linux (RHEL) 8 and are compatible with Linux distributions based on glibc 2.28 or later, for example, Debian 10, RHEL 8, Ubuntu 20.04. - Prebuilt binaries for macOS now require macOS 10.15 or later. - For AIX the minimum supported architecture has been raised from Power 7 to Power 8. Prebuilt binaries for 32-bit Windows will initially not be available due to issues building the V8 dependency in Node.js. We hope to restore 32-bit Windows binaries for Node.js 18 with a future V8 update. Node.js does not support running on operating systems that are no longer supported by their vendor. For operating systems where their vendor has planned to end support earlier than April 2025, such as Windows 8.1 (January 2023) and Windows Server 2012 R2 (October 2023), support for Node.js 18 will end at the earlier date. Full details about the supported toolchains and compilers are documented in the Node.js `BUILDING.md` file. Contributed by Richard Lau in #42292, #42604 and #42659 , and Michaël Zasso in #42105 and #42666. V8 10.1: The V8 engine is updated to version 10.1, which is part of Chromium 101. Compared to the version included in Node.js 17.9.0, the following new features are included: - The `findLast` and `findLastIndex` array methods. - Improvements to the `Intl.Locale` API. - The `Intl.supportedValuesOf` function. - Improved performance of class fields and private class methods (the initialization of them is now as fast as ordinary property stores). The data format returned by the serialization API (`v8.serialize(value)`) has changed, and cannot be deserialized by earlier versions of Node.js. On the other hand, it is still possible to deserialize the previous format, as the API is backwards-compatible. Contributed by Michaël Zasso in #42657. Web Streams API (experimental): Node.js now exposes the experimental implementation of the Web Streams API on the global scope. This means the following APIs are now globally available: - `ReadableStream`, `ReadableStreamDefaultReader`, `ReadableStreamBYOBReader`, `ReadableStreamBYOBRequest`, `ReadableByteStreamController`, `ReadableStreamDefaultController`, `TransformStream`, `TransformStreamDefaultController`, `WritableStream`, `WritableStreamDefaultWriter`, `WritableStreamDefaultController`, `ByteLengthQueuingStrategy`, `CountQueuingStrategy`, `TextEncoderStream`, `TextDecoderStream`, `CompressionStream`, `DecompressionStream`. Contributed James Snell in #39062, and Antoine du Hamel in #42225. Other Notable Changes: - (SEMVER-MAJOR) buffer: expose Blob as a global (James M Snell) (#41270) - (SEMVER-MAJOR) child\_process: improve argument validation (Rich Trott) (#41305) - doc: add RafaelGSS to collaborators (RafaelGSS) (#42718) - (SEMVER-MAJOR) http: make TCP noDelay enabled by default (Paolo Insogna) (#42163) - (SEMVER-MAJOR) net: make `server.address()` return an integer for `family` (Antoine du Hamel) (#41431) - (SEMVER-MAJOR) worker: expose BroadcastChannel as a global (James M Snell) (#41271) - (SEMVER-MAJOR) worker: graduate BroadcastChannel to supported (James M Snell) (#41271) Semver-Major Commits: - (SEMVER-MAJOR) assert,util: compare RegExp.lastIndex while using deep equal checks (Ruben Bridgewater) (#41020) - (SEMVER-MAJOR) buffer: refactor `byteLength` to remove outdated optimizations (Rongjian Zhang) (#38545) - (SEMVER-MAJOR) buffer: expose Blob as a global (James M Snell) (#41270) - (SEMVER-MAJOR) buffer: graduate Blob from experimental (James M Snell) (#41270) - (SEMVER-MAJOR) build: make x86 Windows support temporarily experimental (Michaël Zasso) (#42666) - (SEMVER-MAJOR) build: bump macOS deployment target to 10.15 (Richard Lau) (#42292) - (SEMVER-MAJOR) build: downgrade Windows 8.1 and server 2012 R2 to experimental (Michaël Zasso) (#42105) - (SEMVER-MAJOR) child\_process: improve argument validation (Rich Trott) (#41305) - (SEMVER-MAJOR) cluster: make `kill` to be just `process.kill` (Bar Admoni) (#34312) - (SEMVER-MAJOR) crypto: cleanup validation (Mohammed Keyvanzadeh) (#39841) - (SEMVER-MAJOR) crypto: prettify othername in PrintGeneralName (Tobias Nießen) (#42123) - (SEMVER-MAJOR) crypto: fix X509Certificate toLegacyObject (Tobias Nießen) (#42124) - (SEMVER-MAJOR) crypto: use RFC2253 format in PrintGeneralName (Tobias Nießen) (#42002) - (SEMVER-MAJOR) crypto: change default check(Host|Email) behavior (Tobias Nießen) (#41600) - (SEMVER-MAJOR) deps: V8: cherry-pick semver-major commits from 10.2 (Michaël Zasso) (#42657) - (SEMVER-MAJOR) deps: update V8 to 10.1.124.6 (Michaël Zasso) (#42657) - (SEMVER-MAJOR) deps: update V8 to 9.8.177.9 (Michaël Zasso) (#41610) - (SEMVER-MAJOR) deps: update V8 to 9.7.106.18 (Michaël Zasso) (#40907) - (SEMVER-MAJOR) dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion (Antoine du Hamel) (#41431) - (SEMVER-MAJOR) doc: update minimum glibc requirements for Linux (Richard Lau) (#42659) - (SEMVER-MAJOR) doc: update AIX minimum supported arch (Richard Lau) (#42604) - (SEMVER-MAJOR) fs: runtime deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) (#42607) - (SEMVER-MAJOR) http: refactor headersTimeout and requestTimeout logic (Paolo Insogna) (#41263) - (SEMVER-MAJOR) http: make TCP noDelay enabled by default (Paolo Insogna) (#42163) - (SEMVER-MAJOR) lib: enable fetch by default (Michaël Zasso) (#41811) - (SEMVER-MAJOR) lib: replace validator and error (Mohammed Keyvanzadeh) (#41678) - (SEMVER-MAJOR) module,repl: support 'node:'-only core modules (Colin Ihrig) (#42325) - (SEMVER-MAJOR) net: make `server.address()` return an integer for `family` (Antoine du Hamel) (#41431) - (SEMVER-MAJOR) process: disallow some uses of Object.defineProperty() on process.env (Himself65) (#28006) - (SEMVER-MAJOR) process: runtime deprecate multipleResolves (Benjamin Gruenbaum) (#41896) - (SEMVER-MAJOR) readline: fix question still called after closed (Xuguang Mei) (#42464) - (SEMVER-MAJOR) stream: remove thenable support (Robert Nagy) (#40773) - (SEMVER-MAJOR) stream: expose web streams globals, remove runtime experimental warning (Antoine du Hamel) (#42225) - (SEMVER-MAJOR) stream: need to cleanup event listeners if last stream is readable (Xuguang Mei) (#41954) - (SEMVER-MAJOR) stream: revert revert `map` spec compliance (Benjamin Gruenbaum) (#41933) - (SEMVER-MAJOR) stream: throw invalid arg type from End Of Stream (Jithil P Ponnan) (#41766) - (SEMVER-MAJOR) stream: don't emit finish after destroy (Robert Nagy) (#40852) - (SEMVER-MAJOR) stream: add errored and closed props (Robert Nagy) (#40696) - (SEMVER-MAJOR) test: add initial test module (Colin Ihrig) (#42325) - (SEMVER-MAJOR) timers: refactor internal classes to ES2015 syntax (Rabbit) (#37408) - (SEMVER-MAJOR) tls: represent registeredID numerically always (Tobias Nießen) (#41561) - (SEMVER-MAJOR) tls: move tls.parseCertString to end-of-life (Tobias Nießen) (#41479) - (SEMVER-MAJOR) url: throw on NULL in IPv6 hostname (Rich Trott) (#42313) - (SEMVER-MAJOR) v8: make v8.writeHeapSnapshot() error codes consistent (Darshan Sen) (#42577) - (SEMVER-MAJOR) v8: make writeHeapSnapshot throw if fopen fails (Antonio Román) (#41373) - (SEMVER-MAJOR) worker: expose BroadcastChannel as a global (James M Snell) (#41271) - (SEMVER-MAJOR) worker: graduate BroadcastChannel to supported (James M Snell) (#41271) PR-URL: #42262

Notable Changes: Deprecations and Removals: - (SEMVER-MAJOR) fs: runtime deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) (nodejs#42607) - (SEMVER-MAJOR) dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) process: runtime deprecate multipleResolves (Benjamin Gruenbaum) (nodejs#41896) - (SEMVER-MAJOR) stream: remove thenable support (Robert Nagy) (nodejs#40773) - (SEMVER-MAJOR) tls: move tls.parseCertString to end-of-life (Tobias Nießen) (nodejs#41479) fetch (experimental): An experimental fetch API is available on the global scope by default. The implementation is based upon https://undici.nodejs.org/#/, an HTTP/1.1 client written for Node.js by contributors to the project. Through this addition, the following globals are made available: `fetch` , `FormData`, `Headers`, `Request`, `Response`. Disable this API with the `--no-experimental-fetch` command-line flag. Contributed by Michaël Zasso in nodejs#41811. HTTP Timeouts: `server.headersTimeout`, which limits the amount of time the parser will wait to receive the complete HTTP headers, is now set to `60000` (60 seconds) by default. `server.requestTimeout`, which sets the timeout value in milliseconds for receiving the entire request from the client, is now set to `300000` (5 minutes) by default. If these timeouts expire, the server responds with status 408 without forwarding the request to the request listener and then closes the connection. Both timeouts must be set to a non-zero value to protect against potential Denial-of-Service attacks in case the server is deployed without a reverse proxy in front. Contributed by Paolo Insogna in nodejs#41263. Test Runner module (experimental): The `node:test` module facilitates the creation of JavaScript tests that report results in TAP format. This module is only available under the `node:` scheme. Contributed by Colin Ihrig in nodejs#42325. Toolchain and Compiler Upgrades: - Prebuilt binaries for Linux are now built on Red Hat Enterprise Linux (RHEL) 8 and are compatible with Linux distributions based on glibc 2.28 or later, for example, Debian 10, RHEL 8, Ubuntu 20.04. - Prebuilt binaries for macOS now require macOS 10.15 or later. - For AIX the minimum supported architecture has been raised from Power 7 to Power 8. Prebuilt binaries for 32-bit Windows will initially not be available due to issues building the V8 dependency in Node.js. We hope to restore 32-bit Windows binaries for Node.js 18 with a future V8 update. Node.js does not support running on operating systems that are no longer supported by their vendor. For operating systems where their vendor has planned to end support earlier than April 2025, such as Windows 8.1 (January 2023) and Windows Server 2012 R2 (October 2023), support for Node.js 18 will end at the earlier date. Full details about the supported toolchains and compilers are documented in the Node.js `BUILDING.md` file. Contributed by Richard Lau in nodejs#42292, nodejs#42604 and nodejs#42659 , and Michaël Zasso in nodejs#42105 and nodejs#42666. V8 10.1: The V8 engine is updated to version 10.1, which is part of Chromium 101. Compared to the version included in Node.js 17.9.0, the following new features are included: - The `findLast` and `findLastIndex` array methods. - Improvements to the `Intl.Locale` API. - The `Intl.supportedValuesOf` function. - Improved performance of class fields and private class methods (the initialization of them is now as fast as ordinary property stores). The data format returned by the serialization API (`v8.serialize(value)`) has changed, and cannot be deserialized by earlier versions of Node.js. On the other hand, it is still possible to deserialize the previous format, as the API is backwards-compatible. Contributed by Michaël Zasso in nodejs#42657. Web Streams API (experimental): Node.js now exposes the experimental implementation of the Web Streams API on the global scope. This means the following APIs are now globally available: - `ReadableStream`, `ReadableStreamDefaultReader`, `ReadableStreamBYOBReader`, `ReadableStreamBYOBRequest`, `ReadableByteStreamController`, `ReadableStreamDefaultController`, `TransformStream`, `TransformStreamDefaultController`, `WritableStream`, `WritableStreamDefaultWriter`, `WritableStreamDefaultController`, `ByteLengthQueuingStrategy`, `CountQueuingStrategy`, `TextEncoderStream`, `TextDecoderStream`, `CompressionStream`, `DecompressionStream`. Contributed James Snell in nodejs#39062, and Antoine du Hamel in nodejs#42225. Other Notable Changes: - (SEMVER-MAJOR) buffer: expose Blob as a global (James M Snell) (nodejs#41270) - (SEMVER-MAJOR) child\_process: improve argument validation (Rich Trott) (nodejs#41305) - doc: add RafaelGSS to collaborators (RafaelGSS) (nodejs#42718) - (SEMVER-MAJOR) http: make TCP noDelay enabled by default (Paolo Insogna) (nodejs#42163) - (SEMVER-MAJOR) net: make `server.address()` return an integer for `family` (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) worker: expose BroadcastChannel as a global (James M Snell) (nodejs#41271) - (SEMVER-MAJOR) worker: graduate BroadcastChannel to supported (James M Snell) (nodejs#41271) Semver-Major Commits: - (SEMVER-MAJOR) assert,util: compare RegExp.lastIndex while using deep equal checks (Ruben Bridgewater) (nodejs#41020) - (SEMVER-MAJOR) buffer: refactor `byteLength` to remove outdated optimizations (Rongjian Zhang) (nodejs#38545) - (SEMVER-MAJOR) buffer: expose Blob as a global (James M Snell) (nodejs#41270) - (SEMVER-MAJOR) buffer: graduate Blob from experimental (James M Snell) (nodejs#41270) - (SEMVER-MAJOR) build: make x86 Windows support temporarily experimental (Michaël Zasso) (nodejs#42666) - (SEMVER-MAJOR) build: bump macOS deployment target to 10.15 (Richard Lau) (nodejs#42292) - (SEMVER-MAJOR) build: downgrade Windows 8.1 and server 2012 R2 to experimental (Michaël Zasso) (nodejs#42105) - (SEMVER-MAJOR) child\_process: improve argument validation (Rich Trott) (nodejs#41305) - (SEMVER-MAJOR) cluster: make `kill` to be just `process.kill` (Bar Admoni) (nodejs#34312) - (SEMVER-MAJOR) crypto: cleanup validation (Mohammed Keyvanzadeh) (nodejs#39841) - (SEMVER-MAJOR) crypto: prettify othername in PrintGeneralName (Tobias Nießen) (nodejs#42123) - (SEMVER-MAJOR) crypto: fix X509Certificate toLegacyObject (Tobias Nießen) (nodejs#42124) - (SEMVER-MAJOR) crypto: use RFC2253 format in PrintGeneralName (Tobias Nießen) (nodejs#42002) - (SEMVER-MAJOR) crypto: change default check(Host|Email) behavior (Tobias Nießen) (nodejs#41600) - (SEMVER-MAJOR) deps: V8: cherry-pick semver-major commits from 10.2 (Michaël Zasso) (nodejs#42657) - (SEMVER-MAJOR) deps: update V8 to 10.1.124.6 (Michaël Zasso) (nodejs#42657) - (SEMVER-MAJOR) deps: update V8 to 9.8.177.9 (Michaël Zasso) (nodejs#41610) - (SEMVER-MAJOR) deps: update V8 to 9.7.106.18 (Michaël Zasso) (nodejs#40907) - (SEMVER-MAJOR) dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) doc: update minimum glibc requirements for Linux (Richard Lau) (nodejs#42659) - (SEMVER-MAJOR) doc: update AIX minimum supported arch (Richard Lau) (nodejs#42604) - (SEMVER-MAJOR) fs: runtime deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) (nodejs#42607) - (SEMVER-MAJOR) http: refactor headersTimeout and requestTimeout logic (Paolo Insogna) (nodejs#41263) - (SEMVER-MAJOR) http: make TCP noDelay enabled by default (Paolo Insogna) (nodejs#42163) - (SEMVER-MAJOR) lib: enable fetch by default (Michaël Zasso) (nodejs#41811) - (SEMVER-MAJOR) lib: replace validator and error (Mohammed Keyvanzadeh) (nodejs#41678) - (SEMVER-MAJOR) module,repl: support 'node:'-only core modules (Colin Ihrig) (nodejs#42325) - (SEMVER-MAJOR) net: make `server.address()` return an integer for `family` (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) process: disallow some uses of Object.defineProperty() on process.env (Himself65) (nodejs#28006) - (SEMVER-MAJOR) process: runtime deprecate multipleResolves (Benjamin Gruenbaum) (nodejs#41896) - (SEMVER-MAJOR) readline: fix question still called after closed (Xuguang Mei) (nodejs#42464) - (SEMVER-MAJOR) stream: remove thenable support (Robert Nagy) (nodejs#40773) - (SEMVER-MAJOR) stream: expose web streams globals, remove runtime experimental warning (Antoine du Hamel) (nodejs#42225) - (SEMVER-MAJOR) stream: need to cleanup event listeners if last stream is readable (Xuguang Mei) (nodejs#41954) - (SEMVER-MAJOR) stream: revert revert `map` spec compliance (Benjamin Gruenbaum) (nodejs#41933) - (SEMVER-MAJOR) stream: throw invalid arg type from End Of Stream (Jithil P Ponnan) (nodejs#41766) - (SEMVER-MAJOR) stream: don't emit finish after destroy (Robert Nagy) (nodejs#40852) - (SEMVER-MAJOR) stream: add errored and closed props (Robert Nagy) (nodejs#40696) - (SEMVER-MAJOR) test: add initial test module (Colin Ihrig) (nodejs#42325) - (SEMVER-MAJOR) timers: refactor internal classes to ES2015 syntax (Rabbit) (nodejs#37408) - (SEMVER-MAJOR) tls: represent registeredID numerically always (Tobias Nießen) (nodejs#41561) - (SEMVER-MAJOR) tls: move tls.parseCertString to end-of-life (Tobias Nießen) (nodejs#41479) - (SEMVER-MAJOR) url: throw on NULL in IPv6 hostname (Rich Trott) (nodejs#42313) - (SEMVER-MAJOR) v8: make v8.writeHeapSnapshot() error codes consistent (Darshan Sen) (nodejs#42577) - (SEMVER-MAJOR) v8: make writeHeapSnapshot throw if fopen fails (Antonio Román) (nodejs#41373) - (SEMVER-MAJOR) worker: expose BroadcastChannel as a global (James M Snell) (nodejs#41271) - (SEMVER-MAJOR) worker: graduate BroadcastChannel to supported (James M Snell) (nodejs#41271) PR-URL: nodejs#42262

nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Jul 11, 2020

Trott reviewed Jul 11, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

mscdex reviewed Jul 11, 2020

View reviewed changes

test/parallel/test-cluster-worker-kill-signal.js Outdated Show resolved Hide resolved

mscdex reviewed Jul 11, 2020

View reviewed changes

test/parallel/test-cluster-worker-kill-signal.js Outdated Show resolved Hide resolved

mscdex reviewed Jul 11, 2020

View reviewed changes

test/parallel/test-cluster-worker-kill-signal.js Outdated Show resolved Hide resolved

mscdex reviewed Jul 11, 2020

View reviewed changes

test/parallel/test-cluster-worker-kill-signal.js Outdated Show resolved Hide resolved

bnoordhuis reviewed Jul 12, 2020

View reviewed changes

doc/api/cluster.md Outdated Show resolved Hide resolved

test/parallel/test-cluster-worker-kill-signal.js Outdated Show resolved Hide resolved

test/parallel/test-cluster-worker-kill-signal.js Outdated Show resolved Hide resolved

bnoordhuis added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 12, 2020

RaisinTen added the review wanted PRs that need reviews. label Jan 22, 2021

This comment has been minimized.

Sign in to view

baradm100 force-pushed the master branch from a226e5a to 0bb6dea Compare January 22, 2021 14:58

BridgeAR reviewed Mar 18, 2021

View reviewed changes

doc/api/cluster.md Outdated Show resolved Hide resolved

JamesMGreene mentioned this pull request Mar 26, 2021

Graceful vs forceful killing strategy seems backwards? hunterloftis/throng#41

Open

guybedford force-pushed the master branch from dc5a5da to 8e46568 Compare March 29, 2021 21:33

Bar Admoni added 11 commits February 4, 2022 13:57

cluster: make kill to be just process.kill

4fb861a

Make `Worker.prototype.kill` to be just process.kill without preforming graceful disconnect beforehand. Refs: nodejs#33715

Remove from README

fba0315

Improve test-cluster-worker-kill-signal readbility

c1dc038

Addressing @mscdex comments

60d10ca

Moved the assertion to the when the cluster is exiting

13902f2

Adding numberOfWorkers assertion

9af5aca

Addressing @bnoordhuis comments

84b8cf0

Make the assersion in the test and not in the end

7de8040

as suggested by @bnoordhuis

Align terminology

7f93807

Fix markdown lint

616a414

Re-fix markdown lint

080d8d4

baradm100 force-pushed the master branch from d48aa56 to 080d8d4 Compare February 4, 2022 11:59

Revert README.md

99b7db7

tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2022

aduh95 approved these changes Feb 4, 2022

View reviewed changes

aduh95 merged commit 38007df into nodejs:master Feb 4, 2022

BethGriggs mentioned this pull request Mar 9, 2022

2022-04-19, Version 18.0.0 (Current) #42262

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cluster: make kill to be just process.kill #34312

cluster: make kill to be just process.kill #34312

baradm100 commented Jul 11, 2020 •

edited

Loading

Trott commented Jul 11, 2020

baradm100 commented Jul 11, 2020

baradm100 commented Jul 11, 2020

bnoordhuis left a comment

baradm100 commented Jul 12, 2020 •

edited

Loading

baradm100 commented Jul 12, 2020

bnoordhuis commented Jul 13, 2020

PoojaDurgad commented Jan 21, 2021

baradm100 commented Jan 22, 2021

This comment has been minimized.

This comment has been minimized.

RaisinTen commented Jan 22, 2021

baradm100 commented Jan 22, 2021

nodejs-github-bot commented Jan 22, 2021

BridgeAR commented Mar 18, 2021

baradm100 commented May 14, 2021

aduh95 commented Sep 15, 2021

baradm100 commented Feb 4, 2022

nodejs-github-bot commented Feb 4, 2022

nodejs-github-bot commented Feb 4, 2022

aduh95 commented Feb 4, 2022

cluster: make kill to be just process.kill #34312

cluster: make kill to be just process.kill #34312

Conversation

baradm100 commented Jul 11, 2020 • edited Loading

Issue

Checklist

Trott commented Jul 11, 2020

baradm100 commented Jul 11, 2020

baradm100 commented Jul 11, 2020

bnoordhuis left a comment

Choose a reason for hiding this comment

baradm100 commented Jul 12, 2020 • edited Loading

baradm100 commented Jul 12, 2020

bnoordhuis commented Jul 13, 2020

PoojaDurgad commented Jan 21, 2021

baradm100 commented Jan 22, 2021

This comment has been minimized.

This comment has been minimized.

RaisinTen commented Jan 22, 2021

baradm100 commented Jan 22, 2021

nodejs-github-bot commented Jan 22, 2021

BridgeAR commented Mar 18, 2021

baradm100 commented May 14, 2021

aduh95 commented Sep 15, 2021

baradm100 commented Feb 4, 2022

nodejs-github-bot commented Feb 4, 2022

nodejs-github-bot commented Feb 4, 2022

aduh95 commented Feb 4, 2022

baradm100 commented Jul 11, 2020 •

edited

Loading

baradm100 commented Jul 12, 2020 •

edited

Loading