Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use mustCall() in pummel test #34327

Closed
wants to merge 0 commits into from
Closed

test: use mustCall() in pummel test #34327

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 12, 2020

Replace 'exit' check with common.mustCall().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 12, 2020
@Trott

This comment has been minimized.

Sign in to view
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 13, 2020
@Trott
Copy link
Member Author

Trott commented Jul 13, 2020 •
edited
Loading

Let's try again, without the typo in the PR number...

pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15351/ ✅

Trott added a commit that referenced this pull request Jul 15, 2020
@Trott
test: use mustCall() in pummel test
3b13032 
Replace 'exit' check with common.mustCall().

PR-URL: #34327
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jul 15, 2020

Landed in 3b13032

@Trott Trott closed this Jul 15, 2020
@Trott Trott deleted the mustcall-pummel branch July 15, 2020 02:29
MylesBorins pushed a commit that referenced this pull request Jul 15, 2020
@Trott @MylesBorins
test: use mustCall() in pummel test
04a65d4 
Replace 'exit' check with common.mustCall().

PR-URL: #34327
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 15, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
@Trott @MylesBorins
test: use mustCall() in pummel test
58dfeac 
Replace 'exit' check with common.mustCall().

PR-URL: #34327
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@Trott @cjihrig
test: use mustCall() in pummel test
c306b8d 
Replace 'exit' check with common.mustCall().

PR-URL: #34327
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: use mustCall() in pummel test
a1ab020 
Replace 'exit' check with common.mustCall().

PR-URL: #34327
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: use mustCall() in pummel test
bd3cef7 
Replace 'exit' check with common.mustCall().

PR-URL: #34327
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jasnell @addaleax @lpinca @targos @nodejs-github-bot