Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: do not write to fixtures dir in test-watch-file #34376

Closed
wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 15, 2020

Switch to tmpDir rather than fixtures for file writing.

Checklist

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 15, 2020
@Trott

This comment has been minimized.

@Trott
Copy link
Member Author

Trott commented Jul 17, 2020

@nodejs/testing

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 17, 2020
@Trott
Copy link
Member Author

Trott commented Jul 17, 2020

Trott added a commit to Trott/io.js that referenced this pull request Jul 17, 2020
Switch to tmpDir rather than fixtures for file writing.

PR-URL: nodejs#34376
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott closed this Jul 17, 2020
@Trott
Copy link
Member Author

Trott commented Jul 17, 2020

Landed in d379b00

@Trott Trott deleted the fixshture branch July 17, 2020 15:44
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
Switch to tmpDir rather than fixtures for file writing.

PR-URL: #34376
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
Switch to tmpDir rather than fixtures for file writing.

PR-URL: #34376
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Switch to tmpDir rather than fixtures for file writing.

PR-URL: #34376
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Switch to tmpDir rather than fixtures for file writing.

PR-URL: #34376
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants