Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-heapdump-zlib #34499

Closed

Conversation

puzpuzpuz
Copy link
Member

Refs: #34048

Fixes test/pummel/test-heapdump-zlib.js which was broken by #34048.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@puzpuzpuz puzpuzpuz added zlib Issues and PRs related to the zlib subsystem. test Issues and PRs related to the tests. labels Jul 23, 2020
@puzpuzpuz puzpuzpuz force-pushed the fix/broken-pummel-test-for-zlib branch from 50910cb to 42a4793 Compare July 23, 2020 20:29
@puzpuzpuz puzpuzpuz force-pushed the fix/broken-pummel-test-for-zlib branch from 42a4793 to 6b6841c Compare July 23, 2020 20:32
@puzpuzpuz puzpuzpuz changed the title test: fix pummel zlib test test: fix test-heapdump-zlib Jul 23, 2020
@puzpuzpuz puzpuzpuz force-pushed the fix/broken-pummel-test-for-zlib branch from 6b6841c to 35d87dc Compare July 23, 2020 20:38
@puzpuzpuz puzpuzpuz force-pushed the fix/broken-pummel-test-for-zlib branch from 35d87dc to e2fef24 Compare July 23, 2020 20:40
@richardlau
Copy link
Member

I've requested a pummel CI run (queued): https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15556/

@nodejs-github-bot

This comment has been minimized.

@richardlau
Copy link
Member

If the CI's come back green I'd suggest fast tracking to unbreak the daily builds.

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 23, 2020
@Trott
Copy link
Member

Trott commented Jul 23, 2020

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Trott pushed a commit that referenced this pull request Jul 24, 2020
PR-URL: #34499
Refs: #34048
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Jul 24, 2020

Landed in d1e4e8e

Thanks for the quick fix!

@Trott Trott closed this Jul 24, 2020
@puzpuzpuz puzpuzpuz deleted the fix/broken-pummel-test-for-zlib branch July 24, 2020 06:58
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
PR-URL: #34499
Refs: #34048
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34499
Refs: #34048
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34499
Refs: #34048
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants