Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: don't run test-asan workflow on non-master pushes #34509

Closed
wants to merge 1 commit into from
Closed

build: don't run test-asan workflow on non-master pushes #34509

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

Refs: #34464

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 24, 2020
@richardlau richardlau added the build Issues and PRs related to build files or the CI. label Jul 24, 2020
@mmarchini
Copy link
Contributor

Fast track?

@mmarchini mmarchini added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 25, 2020
@gengjiawen
Copy link
Member

Landed in b2c08f2

@gengjiawen gengjiawen closed this Jul 27, 2020
gengjiawen pushed a commit that referenced this pull request Jul 27, 2020
@richardlau @gengjiawen
build: don't run test-asan workflow on non-master pushes
b2c08f2 
PR-URL: #34509
Refs: #34464
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@richardlau richardlau deleted the asan branch July 27, 2020 10:01
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@richardlau @MylesBorins
build: don't run test-asan workflow on non-master pushes
cce1f3e 
PR-URL: #34509
Refs: #34464
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmarchini mmarchini mmarchini approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@richardlau @mmarchini @gengjiawen @addaleax @lpinca @codebytere @nodejs-github-bot