Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add ref comment to tests #34516

Merged
merged 0 commits into from
Jul 28, 2020
Merged

test: add ref comment to tests #34516

merged 0 commits into from
Jul 28, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 26, 2020

Because the GitHub issue referred to by the test names is in an old repository, put a link to it in a comment in each of test/pummel/test-regress-GH-814.js and test/pummel/test-regress-GH-814_2.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 26, 2020
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 26, 2020
@Trott
Copy link
Member Author

Trott commented Jul 26, 2020

Pummel tests don't run in pull-request CI (yet) and it's adding a comment only, so I think GitHub Actions CI is sufficient here.

Trott added a commit to Trott/io.js that referenced this pull request Jul 28, 2020
Because the GitHub issue referred to by the test name is in an old
repository, put a link to it in a comment in
test/pummel/test-regress-GH-814.js.

PR-URL: nodejs#34516
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@Trott Trott closed this Jul 28, 2020
@Trott Trott merged commit 8598ab8 into nodejs:master Jul 28, 2020
@Trott
Copy link
Member Author

Trott commented Jul 28, 2020

Landed in fe2a7f0...8598ab8

@Trott Trott deleted the add-ref branch July 28, 2020 14:13
ruyadorno pushed a commit that referenced this pull request Jul 28, 2020
Because the GitHub issue referred to by the test name is in an old
repository, put a link to it in a comment in
test/pummel/test-regress-GH-814.js.

PR-URL: #34516
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
ruyadorno pushed a commit that referenced this pull request Jul 28, 2020
Because the GitHub issue referred to by the test name is in an old
repository, put a link to it in a comment in
test/pummel/test-regress-GH-814_2.js.

PR-URL: #34516
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
ruyadorno pushed a commit that referenced this pull request Jul 28, 2020
Because the GitHub issue referred to by the test name is in an old
repository, put a link to it in a comment in
test/pummel/test-regress-GH-814.js.

PR-URL: #34516
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
ruyadorno pushed a commit that referenced this pull request Jul 28, 2020
Because the GitHub issue referred to by the test name is in an old
repository, put a link to it in a comment in
test/pummel/test-regress-GH-814_2.js.

PR-URL: #34516
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
ruyadorno pushed a commit that referenced this pull request Jul 29, 2020
Because the GitHub issue referred to by the test name is in an old
repository, put a link to it in a comment in
test/pummel/test-regress-GH-814.js.

PR-URL: #34516
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
ruyadorno pushed a commit that referenced this pull request Jul 29, 2020
Because the GitHub issue referred to by the test name is in an old
repository, put a link to it in a comment in
test/pummel/test-regress-GH-814_2.js.

PR-URL: #34516
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Because the GitHub issue referred to by the test name is in an old
repository, put a link to it in a comment in
test/pummel/test-regress-GH-814.js.

PR-URL: #34516
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Because the GitHub issue referred to by the test name is in an old
repository, put a link to it in a comment in
test/pummel/test-regress-GH-814_2.js.

PR-URL: #34516
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Because the GitHub issue referred to by the test name is in an old
repository, put a link to it in a comment in
test/pummel/test-regress-GH-814.js.

PR-URL: #34516
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Because the GitHub issue referred to by the test name is in an old
repository, put a link to it in a comment in
test/pummel/test-regress-GH-814_2.js.

PR-URL: #34516
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants