Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix C++ import checker argument expansion #34582

Closed
wants to merge 4 commits into from
Closed

tools: fix C++ import checker argument expansion #34582

wants to merge 4 commits into from

Commits on Jul 31, 2020

  1. src: fix linter failures 

    Fix linter failures when running the linter on all source files.
    @addaleax
    addaleax committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    ddc7467 View commit details
    Browse the repository at this point in the history

  2. tools: fix C++ import checker argument expansion 

    Makefile assumes that it can pass a list of files to the import
checker, whereas the import checker expects a single argument
that is interpreted as a blob.

Fix that mismatch by accepting multiple arguments in the import
checker.

Refs: nodejs#34565
    @addaleax
    addaleax committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    22c467d View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2020

  1. fixup! tools: fix C++ import checker argument expansion 

    Co-authored-by: Richard Lau <[email protected]>
    @addaleax @richardlau
    addaleax and richardlau committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    de6c455 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2020

  1. fixup! src: fix linter failures

    @addaleax
    addaleax committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    57be4cd View commit details
    Browse the repository at this point in the history