Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add padding in the sidebar column #34665

Closed
wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 7, 2020

When doc pages are too long, the sidebar nav menu gets a bit ugly.

Before
image

After
image

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 7, 2020
@Trott
Copy link
Member

Trott commented Aug 9, 2020

@nodejs/website

@DerekNonGeneric DerekNonGeneric added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 11, 2020
@jasnell
Copy link
Member

jasnell commented Aug 11, 2020

Landed in f280d2c

@jasnell jasnell closed this Aug 11, 2020
jasnell pushed a commit that referenced this pull request Aug 11, 2020
PR-URL: #34665
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
PR-URL: #34665
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
PR-URL: #34665
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34665
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34665
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
@aduh95 aduh95 deleted the doc-sidebar-padding branch November 14, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants