Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: prefer uv_gettimeofday over gettimeofday(2) #34689

Closed
wants to merge 1 commit into from
Closed

src: prefer uv_gettimeofday over gettimeofday(2) #34689

wants to merge 1 commit into from

Conversation

juanarbol
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 9, 2020
addaleax
addaleax reviewed Aug 9, 2020
View reviewed changes
src/util.cc Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32694/

@juanarbol
Copy link
Member Author

juanarbol commented Aug 9, 2020 •
edited
Loading

Closing, this can not be built on macOS and ARM

@juanarbol juanarbol closed this Aug 9, 2020
This was referenced Aug 11, 2020
Open
Open
Open
Open
Open
Open
Open
Open
@juanarbol juanarbol deleted the juanarbol/prefer-libuv-time branch January 19, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax left review comments

@gengjiawen gengjiawen gengjiawen left review comments

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@juanarbol @nodejs-github-bot @bnoordhuis @addaleax @gengjiawen @richardlau