Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger: propagate --debug-port= to debuggee #3470

Merged
merged 1 commit into from
May 25, 2016
Merged

debugger: propagate --debug-port= to debuggee #3470

merged 1 commit into from
May 25, 2016

Commits on May 25, 2016

  1. debugger: propagate --debug-port= to debuggee 

    Before this commit `node --debug-port=1234 debug t.js` ignored the
--debug-port= argument, binding to the default port 5858 instead,
making it impossible to debug more than one process on the same
machine that way.

This commit also reduces the number of places where the default port
is hard-coded by one.

Fixes: nodejs#3345
PR-URL: nodejs#3470
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @bnoordhuis
    bnoordhuis committed May 25, 2016
    Configuration menu
    Copy the full SHA
    18fb4f9 View commit details
    Browse the repository at this point in the history