build: move compiling for Windows ARM64 to Tier 2 #34721
Conversation
joaocgreis
added
windows
|
I guess discussion here should focus on how close this comes to our Tier 2 definition:
Given that there's an opt-in checkbox in a Jenkins subjob that gets compilation happening does it get close enough? Do we need to extend that a bit more to make a daily test job against master to get closer? I don't imagine too many people being aware of the tickbox or thinking to regularly run these jobs outside of one or two people. It strictly meets "The Node.js Build Working Group maintains infrastructure for full test coverage." but "Test failures on tier 2 platforms will block releases" suggests that it's tied into our CI in such a way that failures would be noticed by someone preparing for releases. |
|
I agree this does not meet the definition of Tier 2 if we consider testing, but my goal is to have it only for compilation. The Jenkins change in nodejs/build#2408 makes compilation run on every PR, so issues compiling for ARM64 will be visible well before releases. Only running the tests with the compiled binary is behind an opt-in checkbox, and tests do not need to pass for PRs nor releases. My objective here is to keep compilation working, as it is very easy to break. If compilation works, it is likely that the produced binary works and it is much easier to investigate and fix other issues with it. |
There was a problem hiding this comment.
The Jenkins change in nodejs/build#2408 makes compilation run on every PR
I missed that, and in that case this makes sense the way it's spelled out
|
Landed in c2771dc |
PR-URL: #34721 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #34721 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #34721 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Support for cross-compiling for Windows ARM64 was added recently. This moves Windows ARM64 compilation to Tier 2.
We don't yet have reliable machines that we can connect to Jenkins to run CI, so it's too soon to move all Windows ARM64 to Tier 2. We already publish unofficial builds, however a regression has prevented us from publishing releases after v12.15.0. Moving to Tier 2 should prevent such regressions while we wait for reliable hardware for testing.
This depends on nodejs/build#2408
cc @nodejs/build @nodejs/platform-windows
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes