meta: add TSC as owner of governance-related docs #34737
Conversation
|
Review requested:
|
nodejs-github-bot
added
the
meta
|
Also @nodejs/community-committee since this PR will add you as owner of some files :) |
|
Likely good to include |
|
Right, missed that one |
|
Appreciate you actively including CommComm ❤️ |
mmarchini
force-pushed
the
codeowners-tsc
branch
from
6779a44
to
2b9c839
Compare
.github/CODEOWNERS
Outdated
| /CODE_OF_CONDUCT.md @nodejs/tsc @nodejs/community-committee | ||
| /CONTRIBUTING.md @nodejs/tsc @nodejs/community-committee | ||
| /LICENSE @nodejs/tsc @nodejs/community-committee | ||
| /GOVERNANCE.md @nodejs/tsc @nodejs/community-committee |
There was a problem hiding this comment.
So, historically the CommComm has not been an owner of Governance / Contributing of nodejs/node. I'm not saying that we can't make this change (I've already approved this PR) but I do think this is a fairly large change from what we've done until now... and AFAICT from the charter of the commcomm it is slightly out of scope imho.
I could see how Code of Conduct, License, and potentially Contributing could fall under CommComm but I'm a little less easy about including governance, specifically because this is something the TSC is chartered to manage. CommComm members do not automatically get commit rights for this repo, so it seems a bit out of scope. For the record I would say the same thing about auto adding the TSC to the governance document of any working group.
There was a problem hiding this comment.
I have no objection to @MylesBorins’s comments here.
There was a problem hiding this comment.
That makes sense, I'll update :)
There was a problem hiding this comment.
Updated, kept CommComm on License, Contributing and both Code of Conduct files (yes, we have two)
There was a problem hiding this comment.
@MylesBorins ... while that is true, keep in mind that this doesn't change the process for modifying those. It still requires no objections from TSC to modify any part of the governance. There's likely no harm in CommComm being notified of these changes.
There was a problem hiding this comment.
I guess this is semantics about if CodeOwners is being used to automate notifications or if it signals ownership / signoff. I was assuming the latter, but my impression seems to be off.
There was a problem hiding this comment.
It's ... both? ;-) CODEOWNERS is: these are the people who really need to be aware of these changes. Given that we have a Must Object approach rather than a Must Agree approach, however, with the governance docs it still comes down to TSC objections being most critical. That said, if someone from commcomm raises an objection (or anyone else for that matter), there's going to be an effort made to resolve that before moving forward, regardless of CODEOWNERS
There was a problem hiding this comment.
That said, if someone from commcomm raises an objection (or anyone else for that matter), there's going to be an effort made to resolve that before moving forward, regardless of CODEOWNERS
Thinking about this a bit more I think what is most important here is that the TSC is onboard with this specific commitment, and since it at least to me appears to be a deviation from current norms that we have broadly made folks aware of this commitment.
What I would not like to see happen is there be an objection in the future that is simply dismissed, or some form of contention that is created by some folks maybe not being ok with this commimtent.
To be clear I'm +1 on making this committment.
There was a problem hiding this comment.
I wouldn't expect any objections to be dismissed and would be unpleasantly surprised if it happened either today or after we land this. Collaborators can object to any changes to this repository that target the default branch, in which case: 1) consensus attempt is made via discussions in the PR; 2) objection is escalated to the TSC, who can try to mediate or go to a vote if mediation fails. We don't have exceptions for specific files in the current process.
Either way, CODEOWNERS is not mentioned anywhere in our collaboration docs today, which means it has no clear definition yet, and therefore is only used/considered for notifications.
(just describing what we have today, doesn't mean we can't or should make changes in the future)
mmarchini
force-pushed
the
codeowners-tsc
branch
from
2b9c839
to
984429a
Compare
mmarchini
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/34737 ✔ Done loading data for nodejs/node/pull/34737 ----------------------------------- PR info ------------------------------------ Title meta: add TSC as owner of governance-related docs (#34737) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch mmarchini:codeowners-tsc -> nodejs:master Labels meta Commits 1 - meta: add TSC as owner of governance-related docs Committers 1 - Mary Marchini PR-URL: https://github.com/nodejs/node/pull/34737 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Myles Borins Reviewed-By: Matteo Collina Reviewed-By: Gireesh Punathil Reviewed-By: Beth Griggs Reviewed-By: Shelley Vohr Reviewed-By: Trivikram Kamat ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/34737 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Myles Borins Reviewed-By: Matteo Collina Reviewed-By: Gireesh Punathil Reviewed-By: Beth Griggs Reviewed-By: Shelley Vohr Reviewed-By: Trivikram Kamat -------------------------------------------------------------------------------- ✖ No CI runs detected ℹ This PR was created on Tue, 11 Aug 2020 21:25:20 GMT ✔ Approvals: 8 ✔ - Anna Henningsen (@addaleax) (TSC): https://github.com/nodejs/node/pull/34737#pullrequestreview-465441856 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/34737#pullrequestreview-465448967 ✔ - Myles Borins (@MylesBorins) (TSC): https://github.com/nodejs/node/pull/34737#pullrequestreview-465544833 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/34737#pullrequestreview-465634628 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/34737#pullrequestreview-465827310 ✔ - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/34737#pullrequestreview-465833525 ✔ - Shelley Vohr (@codebytere) (TSC): https://github.com/nodejs/node/pull/34737#pullrequestreview-465985239 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/34737#pullrequestreview-466491120 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
github-actions
bot
removed
the
request-ci
mmarchini
added
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 5f78dea |
PR-URL: #34737 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #34737 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #34737 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #34737 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #34737 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes