Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update esm.md #34786

Closed
wants to merge 2 commits into from
Closed

Update esm.md #34786

wants to merge 2 commits into from

Conversation

frank-dspeed
Copy link
Contributor

@frank-dspeed frank-dspeed commented Aug 15, 2020 •
edited by rickyes
Loading

Fixed Reference as the file name is main.mjs and not main.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@frank-dspeed
Update esm.md
e6e8e19 
Fixed Reference as the file name is main.mjs and not main.js
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Aug 15, 2020
@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 15, 2020
DerekNonGeneric
DerekNonGeneric reviewed Aug 15, 2020
View reviewed changes
doc/api/esm.md Outdated Show resolved Hide resolved
DerekNonGeneric
DerekNonGeneric approved these changes Aug 15, 2020
View reviewed changes
Copy link
Contributor

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. I saw this problem a few days ago, but never got around to fixing it myself. Cheers!

@frank-dspeed @DerekNonGeneric
Update doc/api/esm.md
a0f4fb3 
Co-authored-by: Derek Lewis <[email protected]>
@DerekNonGeneric
Copy link
Contributor

Just as a note for a future TODO. We should make all of these like the following:

node --experimental-loader=./https-loader.mjs ./main.mjs

Trott pushed a commit that referenced this pull request Aug 19, 2020
@frank-dspeed @Trott
doc: fix file name to main.mjs and not main.js in esm.md
6e97a73 
PR-URL: #34786
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Aug 19, 2020

Landed in 6e97a73.

Thanks for the contribution! 🎉

@Trott Trott closed this Aug 19, 2020
@frank-dspeed frank-dspeed deleted the patch-1 branch August 19, 2020 07:37
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@frank-dspeed @BethGriggs
doc: fix file name to main.mjs and not main.js in esm.md
fae5df2 
PR-URL: #34786
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@frank-dspeed @BethGriggs
doc: fix file name to main.mjs and not main.js in esm.md
5c987ff 
PR-URL: #34786
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@frank-dspeed @addaleax
doc: fix file name to main.mjs and not main.js in esm.md
49282e4 
PR-URL: #34786
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@frank-dspeed @addaleax
doc: fix file name to main.mjs and not main.js in esm.md
edda492 
PR-URL: #34786
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayed42 ayed42 ayed42 left review comments

@jasnell jasnell jasnell approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes

@MrHeer MrHeer MrHeer approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@frank-dspeed @nodejs-github-bot @DerekNonGeneric @Trott @jasnell @GeoffreyBooth @addaleax @targos @MrHeer @ayed42