test: run REPL preview test regardless of terminal type #34798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
BridgeAR
reviewed
Aug 16, 2020
Yeah, my hope is that the tests fail here (which is why I have this in draft mode) and then pass if we spawn a subprocess with a different |
|
@nodejs/repl |
This comment has been minimized.
This comment has been minimized.
BridgeAR
approved these changes
Aug 19, 2020
Turns out it didn't need to do any spawning. Since the output never goes to the actual terminal anyway, we can set the |
jasnell
approved these changes
Aug 19, 2020
This comment has been minimized.
This comment has been minimized.
7 tasks
mmarchini
approved these changes
Aug 20, 2020
jasnell
added
author ready
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/34798 ✔ Done loading data for nodejs/node/pull/34798 ----------------------------------- PR info ------------------------------------ Title test: run REPL preview test regardless of terminal type (#34798) Author Rich Trott (@Trott) Branch Trott:terminal-type -> nodejs:master Labels author ready, test Commits 2 - test: run REPL preview test regardless of terminal type - fixup! test: run REPL preview test regardless of terminal type Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/34798 Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell Reviewed-By: Mary Marchini ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/34798 Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell Reviewed-By: Mary Marchini -------------------------------------------------------------------------------- ℹ Last Full PR CI on 2020-08-20T02:19:41Z: https://ci.nodejs.org/job/node-test-pull-request/32864/ - Querying data of job/node-test-pull-request/32864/ ✔ Build data downloaded ℹ This PR was created on Sun, 16 Aug 2020 17:37:52 GMT ✔ Approvals: 3 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/34798#pullrequestreview-470512232 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/34798#pullrequestreview-470592782 ✔ - Mary Marchini (@mmarchini) (TSC): https://github.com/nodejs/node/pull/34798#pullrequestreview-471078394 -------------------------------------------------------------------------------- ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 34798 ✔ Downloaded patch to /home/runner/work/node/node/.ncu/34798/patch -------------------------------------------------------------------------------- Applying: test: run REPL preview test regardless of terminal type Applying: fixup! test: run REPL preview test regardless of terminal type ✔ Patches applied There are 2 commits in the PR Please run the following commands to complete landing |
|
Commit queue failed as at the moment it can only handle single commit pull requests (I forgot this too in another PR). This could be landed manually, but it could also be a good candidate to test out nodejs/node-core-utils#473. cc @mmarchini |
mmarchini
pushed a commit
that referenced
this pull request
Aug 20, 2020
PR-URL: #34798 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
|
Landed in 6130cdd |
This was referenced Aug 21, 2020
BethGriggs
pushed a commit
that referenced
this pull request
Aug 24, 2020
PR-URL: #34798 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
11 tasks
Merged
This was referenced Aug 26, 2020
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34798 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34798 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
Merged
targos
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes