Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix some typos and grammar mistakes in issues.md #34800

Closed
wants to merge 1 commit into from
Closed

doc: fix some typos and grammar mistakes in issues.md #34800

wants to merge 1 commit into from

Conversation

HillaShx
Copy link
Contributor

Hello everyone!

I'm a junior developer looking to contribute to this magnificent codebase. As I read through the documentation, I noticed a few typos so now I'm submitting a fix.
Thank you all for your inspiring and wonderful work! 😎

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 16, 2020
@HillaShx HillaShx changed the title Fixed some typos and grammar mistakes in issues.md doc: fix some typos and grammar mistakes in issues.md Aug 16, 2020
benjamingr
benjamingr approved these changes Aug 16, 2020
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

Please also note the commit message guidelines :]

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 17, 2020
rickyes
rickyes approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@rickyes rickyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@jasnell
Copy link
Member

jasnell commented Aug 17, 2020

fast-track?

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 17, 2020
Nelias
Nelias approved these changes Aug 17, 2020
View reviewed changes
Copy link

@Nelias Nelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rickyes pushed a commit that referenced this pull request Aug 18, 2020
@HillaShx @rickyes
doc: fix some typos and grammar mistakes
68ccd16 
PR-URL: #34800
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@rickyes
Copy link
Contributor

rickyes commented Aug 18, 2020

Landed in 68ccd16

@HillaShx congratulations on your first commit to Node.js! 🎉

@rickyes rickyes closed this Aug 18, 2020
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@HillaShx @BethGriggs
doc: fix some typos and grammar mistakes
4b7e118 
PR-URL: #34800
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@HillaShx @BethGriggs
doc: fix some typos and grammar mistakes
3360dcb 
PR-URL: #34800
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@HillaShx @addaleax
doc: fix some typos and grammar mistakes
5ba3d08 
PR-URL: #34800
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@HillaShx @addaleax
doc: fix some typos and grammar mistakes
fd4f561 
PR-URL: #34800
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@trivikr trivikr trivikr approved these changes

@MrHeer MrHeer MrHeer approved these changes

@rickyes rickyes rickyes approved these changes

@Nelias Nelias Nelias approved these changes

@HarshithaKP HarshithaKP HarshithaKP approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.