V14.9.0 proposal

.eslintrc.js

@@ -43,6 +43,7 @@ module.exports = {
     {
       files: [
         'doc/api/esm.md',
+        'doc/api/module.md',
         'doc/api/modules.md',
         'test/es-module/test-esm-type-flag.js',
         'test/es-module/test-esm-type-flag-alias.js',

.github/CODEOWNERS

@@ -5,7 +5,24 @@
 # 3. PRs touching any code with a codeowner must be signed off by at least one
 #    person on the code owner team.
 
+# tsc & commcomm
+
 /.github/CODEOWNERS @nodejs/tsc
+/GOVERNANCE.md @nodejs/tsc
+/onboarding.md @nodejs/tsc
+/CODE_OF_CONDUCT.md @nodejs/tsc @nodejs/community-committee
+/CONTRIBUTING.md @nodejs/tsc @nodejs/community-committee
+/LICENSE @nodejs/tsc @nodejs/community-committee
+/doc/guides/contributing/code-of-conduct.md @nodejs/tsc @nodejs/community-committee
+# TODO(mmarchini): the bot doens't have a notion of precedence, that might
+# change when move the codeowners code to an Action, at which point we can
+# uncomment the line below
+# /doc/guides/contributing/*.md @nodejs/tsc
+/doc/guides/contributing/issues.md @nodejs/tsc
+/doc/guides/contributing/pull-requests.md @nodejs/tsc
+/doc/guides/collaborator-guide.md @nodejs/tsc
+/doc/guides/offboarding.md @nodejs/tsc
+/doc/guides/onboarding-extras.md @nodejs/tsc
 
 # net
 
@@ -21,7 +38,7 @@
 /lib/internal/net.js @nodejs/net
 /lib/internal/socket_list.js @nodejs/net
 /lib/internal/js_stream_socket.js @nodejs/net
-/src/cares_wrap.h @nodejs/net
+/src/cares_wrap.cc @nodejs/net
 /src/connect_wrap.* @nodejs/net
 /src/connection_wrap.* @nodejs/net
 /src/node_sockaddr* @nodejs/net
@@ -41,7 +58,6 @@
 
 /deps/llhttp/* @nodejs/http @nodejs/net
 /doc/api/http.md @nodejs/http @nodejs/net
-/doc/api/http2.md @nodejs/http @nodejs/net
 /lib/_http_* @nodejs/http @nodejs/net
 /lib/http.js @nodejs/http @nodejs/net
 /lib/https.js @nodejs/crypto @nodejs/net @nodejs/http
@@ -51,7 +67,7 @@
 # http2
 
 /deps/nghttp2/* @nodejs/http2 @nodejs/net
-/doc/api/http2.md @nodejs/http2 @nodejs/net
+/doc/api/http2.md @nodejs/http2 @nodejs/http @nodejs/net
 /lib/http2.js @nodejs/http2 @nodejs/net
 /lib/internal/http2/* @nodejs/http2 @nodejs/net
 /src/node_http2* @nodejs/http2 @nodejs/net

.github/workflows/auto-start-ci.yml

@@ -3,12 +3,10 @@ name: Auto Start CI
 
 on:
   schedule:
-    # `schedule` event is used instead of `pull_request` because when a
-    # `pull_requesst` event is triggered on a PR from a fork, GITHUB_TOKEN will
-    # be read-only, and the Action won't have access to any other repository
-    # secrets, which it needs to access Jenkins API. Runs every five minutes
-    # (fastest the scheduler can run). Five minutes is optimistic, it can take
-    # longer to run.
+    # Runs every five minutes (fastest the scheduler can run). Five minutes is
+    # optimistic, it can take longer to run.
+    # To understand why `schedule` is used instead of other events, refer to
+    # ./doc/guides/commit-queue.md
     - cron: "*/5 * * * *"
 
 jobs:

.github/workflows/commit-queue.yml

@@ -0,0 +1,81 @@
+---
+# This action requires the following secrets to be set on the repository:
+#   GH_USER_NAME: GitHub user whose Jenkins and GitHub token are defined below
+#   GH_USER_TOKEN: GitHub user token, to be used by ncu and to push changes
+#   JENKINS_TOKEN: Jenkins token, to be used to check CI status
+
+name: Commit Queue
+
+on:
+  # `schedule` event is used instead of `pull_request` because when a
+  # `pull_request` event is triggered on a PR from a fork, GITHUB_TOKEN will
+  # be read-only, and the Action won't have access to any other repository
+  # secrets, which it needs to access Jenkins API.
+  schedule:
+    - cron: "*/5 * * * *"
+
+jobs:
+  commitQueue:
+    if: github.repository == 'nodejs/node'
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          # A personal token is required because pushing with GITHUB_TOKEN will
+          # prevent commits from running CI after they land on master. It needs
+          # to be set here because `checkout` configures GitHub authentication
+          # for push as well.
+          token: ${{ secrets.GH_USER_TOKEN }}
+
+      # Install dependencies
+      - name: Install Node.js
+        uses: actions/setup-node@v2-beta
+        with:
+          node-version: '12'
+      - name: Install dependencies
+        run: |
+          sudo apt-get install jq -y
+          # TODO(mmarchini): install from npm after next ncu release is out
+          npm install -g 'https://github.com/mmarchini/node-core-utils#commit-queue-branch'
+          # npm install -g node-core-utils
+
+      - name: Set variables
+        run: |
+          echo "::set-env name=REPOSITORY::$(echo ${{ github.repository }} | cut -d/ -f2)"
+          echo "::set-env name=OWNER::${{ github.repository_owner }}"
+
+      - name: Get Pull Requests
+        uses: octokit/[email protected]
+        id: get_mergable_pull_requests
+        with:
+          query: |
+            query release($owner:String!,$repo:String!, $base_ref:String!) {
+              repository(owner:$owner, name:$repo) {
+                pullRequests(baseRefName: $base_ref, labels: ["commit-queue"], states: OPEN, last: 100) {
+                  nodes {
+                    number
+                  }
+                }
+              }
+            }
+          owner: ${{ env.OWNER }}
+          repo: ${{ env.REPOSITORY }}
+          # Commit queue is only enabled for the default branch on the repository
+          # TODO(mmarchini): get the default branch programmatically instead of
+          # assuming `master`
+          base_ref: "master"
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Configure node-core-utils
+        run: |
+          ncu-config set branch master
+          ncu-config set upstream origin
+          ncu-config set username "${{ secrets.GH_USER_NAME }}"
+          ncu-config set token "${{ secrets.GH_USER_TOKEN }}"
+          ncu-config set jenkins_token "${{ secrets.JENKINS_TOKEN }}"
+          ncu-config set repo "${{ env.REPOSITORY }}"
+          ncu-config set owner "${{ env.OWNER }}"
+
+      - name: Start the commit queue
+        run: ./tools/actions/commit-queue.sh ${{ env.OWNER }} ${{ env.REPOSITORY }} ${{ secrets.GITHUB_TOKEN }} $(echo '${{ steps.get_mergable_pull_requests.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')

.github/workflows/linters.yml

@@ -77,3 +77,11 @@ jobs:
         run: |
           make lint-py-build || true
           NODE=$(which node) make lint-py
+
+  lint-codeowners:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: mszostok/[email protected]
+        with:
+          checks: "files,duppatterns"

.github/workflows/misc.yml

@@ -28,3 +28,5 @@ jobs:
         with:
           name: docs
           path: out/doc
+      - name: Check links
+        run: node tools/doc/checkLinks.js .

.gitignore

@@ -130,6 +130,9 @@ _UpgradeReport_Files/
 # Ignore dependencies fetched by deps/v8/tools/node/fetch_deps.py
 /deps/.cipd
 
+# === Rules for Windows vcbuild.bat ===
+/temp-vcbuild
+
 # === Global Rules ===
 # Keep last to avoid being excluded
 *.pyc

BUILDING.md

@@ -110,7 +110,7 @@ platforms. This is true regardless of entries in the table below.
 | Windows          | x64, x86 (WoW64) | >= Windows 8.1/2012 R2          | Tier 1       | <sup>[4](#fn4),[5](#fn5)</sup>    |
 | Windows          | x86 (native)     | >= Windows 8.1/2012 R2          | Tier 1 (running) / Experimental (compiling) <sup>[6](#fn6)</sup> | |
 | Windows          | x64, x86         | Windows Server 2012 (not R2)    | Experimental |                                   |
-| Windows          | arm64            | >= Windows 10                   | Experimental |                                   |
+| Windows          | arm64            | >= Windows 10                   | Tier 2 (compiling) / Experimental (running) |    |
 | macOS            | x64              | >= 10.11                        | Tier 1       |                                   |
 | SmartOS          | x64              | >= 18                           | Tier 2       |                                   |
 | AIX              | ppc64be >=power7 | >= 7.2 TL02                     | Tier 2       |                                   |
@@ -237,7 +237,7 @@ test with Python 3.
 * GNU Make 3.81 or newer
 * Python (see note above)
   * Python 2.7
-  * Python 3.5, 3.6, 3.7, and 3.8.
+  * Python 3.5, 3.6, 3.7, and 3.8
 
 Installation via Linux package manager can be achieved with:
 
@@ -256,7 +256,7 @@ Python 3 users may also need to install `python3-distutils`.
 * Xcode Command Line Tools >= 10 for macOS
 * Python (see note above)
   * Python 2.7
-  * Python 3.5, 3.6, 3.7, and 3.8.
+  * Python 3.5, 3.6, 3.7, and 3.8
 
 macOS users can install the `Xcode Command Line Tools` by running
 `xcode-select --install`. Alternatively, if you already have the full Xcode
@@ -531,7 +531,7 @@ to run it again before invoking `make -j4`.
   [Visual Studio 2017 or 2019](https://visualstudio.microsoft.com/downloads/) or
   the "Visual C++ build tools" workload from the
   [Build Tools](https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019),
-  with the default optional components.
+  with the default optional components
 * Basic Unix tools required for some tests,
   [Git for Windows](https://git-scm.com/download/win) includes Git Bash
   and tools which can be included in the global `PATH`.
@@ -545,12 +545,11 @@ Optional requirements to build the MSI installer package:
 * The [WiX Toolset v3.11](https://wixtoolset.org/releases/) and the
   [Wix Toolset Visual Studio 2017 Extension](https://marketplace.visualstudio.com/items?itemName=RobMensching.WixToolsetVisualStudio2017Extension)
   or the [Wix Toolset Visual Studio 2019 Extension](https://marketplace.visualstudio.com/items?itemName=WixToolset.WixToolsetVisualStudio2019Extension).
+* The [WiX Toolset v3.14](https://wixtoolset.org/releases/) if
+  building for Windows 10 on ARM (ARM64)
 
 Optional requirements for compiling for Windows 10 on ARM (ARM64):
 
-* ARM64 Windows build machine
-  * Due to a GYP limitation, this is required to run compiled code
-    generation tools (like V8's builtins and mksnapshot tools)
 * Visual Studio 15.9.0 or newer
 * Visual Studio optional components
   * Visual C++ compilers and libraries for ARM64
@@ -565,7 +564,7 @@ This script will install the following [Chocolatey](https://chocolatey.org/)
 packages:
 
 * [Git for Windows](https://chocolatey.org/packages/git) with the `git` and
-  Unix tools added to the `PATH`.
+  Unix tools added to the `PATH`
 * [Python 3.x](https://chocolatey.org/packages/python) and
   [legacy Python](https://chocolatey.org/packages/python2)
 * [Visual Studio 2019 Build Tools](https://chocolatey.org/packages/visualstudio2019buildtools)

CHANGELOG.md

@@ -31,7 +31,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V14.md#14.8.0">14.8.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V14.md#14.9.0">14.9.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V14.md#14.8.0">14.8.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V14.md#14.7.0">14.7.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V14.md#14.6.0">14.6.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V14.md#14.5.0">14.5.0</a><br/>

Makefile

@@ -1268,7 +1268,7 @@ LINT_CPP_EXCLUDE += $(wildcard test/js-native-api/??_*/*.cc test/js-native-api/?
 LINT_CPP_EXCLUDE += src/tracing/trace_event.h src/tracing/trace_event_common.h
 
 LINT_CPP_FILES = $(filter-out $(LINT_CPP_EXCLUDE), $(wildcard \
-	benchmark/napi/function_call/binding.cc \
+	benchmark/napi/*/*.cc \
 	src/*.c \
 	src/*.cc \
 	src/*.h \

README.md

@@ -153,8 +153,6 @@ For information about the governance of the Node.js project, see
 ### TSC (Technical Steering Committee)
 
 <!--lint disable prohibited-strings-->
-* [addaleax](https://github.com/addaleax) -
-**Anna Henningsen** &lt;[email protected]&gt; (she/her)
 * [apapirovski](https://github.com/apapirovski) -
 **Anatoli Papirovski** &lt;[email protected]&gt; (he/him)
 * [BethGriggs](https://github.com/BethGriggs) -
@@ -196,6 +194,8 @@ For information about the governance of the Node.js project, see
 
 ### TSC Emeriti
 
+* [addaleax](https://github.com/addaleax) -
+**Anna Henningsen** &lt;[email protected]&gt; (she/her)
 * [bnoordhuis](https://github.com/bnoordhuis) -
 **Ben Noordhuis** &lt;[email protected]&gt;
 * [chrisdickinson](https://github.com/chrisdickinson) -

benchmark/napi/function_args/binding.cc

@@ -2,18 +2,20 @@
 #include <node.h>
 #include <assert.h>
 
-using v8::Isolate;
+using v8::Array;
+using v8::ArrayBuffer;
+using v8::ArrayBufferView;
+using v8::BackingStore;
 using v8::Context;
+using v8::FunctionCallbackInfo;
+using v8::Isolate;
 using v8::Local;
 using v8::MaybeLocal;
-using v8::Value;
 using v8::Number;
-using v8::String;
 using v8::Object;
-using v8::Array;
-using v8::ArrayBufferView;
-using v8::ArrayBuffer;
-using v8::FunctionCallbackInfo;
+using v8::String;
+using v8::Uint32;
+using v8::Value;
 
 void CallWithString(const FunctionCallbackInfo<Value>& args) {
   assert(args.Length() == 1 && args[0]->IsString());
@@ -22,7 +24,7 @@ void CallWithString(const FunctionCallbackInfo<Value>& args) {
     const int32_t length = str->Utf8Length(args.GetIsolate()) + 1;
     char* buf = new char[length];
     str->WriteUtf8(args.GetIsolate(), buf, length);
-    delete [] buf;
+    delete[] buf;
   }
 }
 
@@ -31,7 +33,7 @@ void CallWithArray(const FunctionCallbackInfo<Value>& args) {
   if (args.Length() == 1 && args[0]->IsArray()) {
     const Local<Array> array = args[0].As<Array>();
     uint32_t length = array->Length();
-    for (uint32_t i = 0; i < length; ++ i) {
+    for (uint32_t i = 0; i < length; i++) {
       Local<Value> v;
       v = array->Get(args.GetIsolate()->GetCurrentContext(),
                      i).ToLocalChecked();
@@ -101,24 +103,22 @@ void CallWithTypedarray(const FunctionCallbackInfo<Value>& args) {
     const size_t byte_length = view->ByteLength();
     assert(byte_length > 0);
     assert(view->HasBuffer());
-    Local<ArrayBuffer> buffer;
-    buffer = view->Buffer();
-    ArrayBuffer::Contents contents;
-    contents = buffer->GetContents();
+    Local<ArrayBuffer> buffer = view->Buffer();
+    std::shared_ptr<BackingStore> bs = buffer->GetBackingStore();
     const uint32_t* data = reinterpret_cast<uint32_t*>(
-        static_cast<uint8_t*>(contents.Data()) + byte_offset);
+        static_cast<uint8_t*>(bs->Data()) + byte_offset);
     assert(data);
   }
 }
 
 void CallWithArguments(const FunctionCallbackInfo<Value>& args) {
   assert(args.Length() > 1 && args[0]->IsNumber());
   if (args.Length() > 1 && args[0]->IsNumber()) {
-    int32_t loop = args[0].As<v8::Uint32>()->Value();
+    int32_t loop = args[0].As<Uint32>()->Value();
     for (int32_t i = 1; i < loop; ++i) {
       assert(i < args.Length());
       assert(args[i]->IsUint32());
-      args[i].As<v8::Uint32>()->Value();
+      args[i].As<Uint32>()->Value();
     }
   }
 }

benchmark/process/resourceUsage.js

@@ -0,0 +1,14 @@
+'use strict';
+
+const common = require('../common.js');
+const bench = common.createBenchmark(main, {
+  n: [1e5]
+});
+
+function main({ n }) {
+  bench.start();
+  for (let i = 0; i < n; i++) {
+    process.resourceUsage();
+  }
+  bench.end(n);
+}

common.gypi

@@ -36,7 +36,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.12',
+    'v8_embedder_string': '-node.13',
 
     ##### V8 defaults for Node.js #####
 
@@ -54,6 +54,9 @@
     # Enable disassembler for `--print-code` v8 options
     'v8_enable_disassembler': 1,
 
+    # Sets -dOBJECT_PRINT.
+    'v8_enable_object_print%': 1,
+
     # https://github.com/nodejs/node/pull/22920/files#r222779926
     'v8_enable_handle_zapping': 0,