Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: replace usage of internal stream state with public api #34885

Closed

Conversation

lundibundi
Copy link
Member

Refs: #445

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @nodejs/net

@lundibundi lundibundi added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020
@lundibundi lundibundi requested a review from a team as a code owner August 23, 2020 08:49
@lundibundi lundibundi requested a review from a team August 23, 2020 08:49
@nodejs-github-bot nodejs-github-bot added the net Issues and PRs related to the net subsystem. label Aug 23, 2020
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net
  • @nodejs/quic

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

@lundibundi lundibundi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 29, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 29, 2020
@github-actions
Copy link
Contributor

Landed in a36b7d8

nodejs-github-bot pushed a commit that referenced this pull request Aug 29, 2020
Refs: #445

PR-URL: #34885
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@github-actions github-actions bot closed this Aug 29, 2020
@lundibundi lundibundi deleted the remove-internal-stream-from-net branch August 29, 2020 09:44
richardlau pushed a commit that referenced this pull request Sep 1, 2020
Refs: #445

PR-URL: #34885
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@richardlau richardlau mentioned this pull request Sep 2, 2020
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Refs: #445

PR-URL: #34885
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Refs: #445

PR-URL: #34885
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. net Issues and PRs related to the net subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants