doc: added details around console.timeEnd changes #35027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
console
benjamingr
approved these changes
Sep 3, 2020
lpinca
reviewed
Sep 3, 2020
|
@lpinca done |
addaleax
reviewed
Sep 5, 2020
addaleax
approved these changes
Sep 5, 2020
3 tasks
lpinca
approved these changes
Oct 1, 2020
|
@yashLadha I've also opened #35441 as per #35027 (review) |
lpinca
reviewed
Oct 1, 2020
Since PR nodejs#29251 is merged into the master, the implementation of `console.timeEnd` is not to print the milliseconds on the stdout but instead print a more readable time unit on the console. For example if the total time comes out to be 3456 milliseconds, it will be printed as 3.45 seconds so that it is much more readable and consistent. Referenced PR: nodejs#29251 Fixes: nodejs#35011
lpinca
pushed a commit
that referenced
this pull request
Oct 3, 2020
Since PR #29251 is merged into master, the implementation of `console.timeEnd` is not to print the milliseconds on the stdout but instead print a more readable time unit on the console. For example if the total time comes out to be 3456 milliseconds, it will be printed as 3.45 seconds so that it is much more readable and consistent. PR-URL: #35027 Fixes: #35011 Refs: #29251 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 6139e58. |
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Oct 4, 2020
PR-URL: nodejs#35441 Refs: nodejs#35027 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Oct 6, 2020
Since PR #29251 is merged into master, the implementation of `console.timeEnd` is not to print the milliseconds on the stdout but instead print a more readable time unit on the console. For example if the total time comes out to be 3456 milliseconds, it will be printed as 3.45 seconds so that it is much more readable and consistent. PR-URL: #35027 Fixes: #35011 Refs: #29251 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Oct 6, 2020
PR-URL: #35441 Refs: #35027 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Since PR nodejs#29251 is merged into master, the implementation of `console.timeEnd` is not to print the milliseconds on the stdout but instead print a more readable time unit on the console. For example if the total time comes out to be 3456 milliseconds, it will be printed as 3.45 seconds so that it is much more readable and consistent. PR-URL: nodejs#35027 Fixes: nodejs#35011 Refs: nodejs#29251 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35441 Refs: nodejs#35027 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #35011
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes