test: revise test-policy-integrity #35101
Conversation
|
This greatly speeds the test in some environments. Notably, it means that the test no longer times out most of the time on FreeBSD in CI. Stress test with master showing it failing due to timing out 9 out of 10 times: Stress test with this PR showing it succeeding every time: On master, the one successful time in CI, it took 216 seconds. Every other time, it timed out after 240 seconds. With this PR, it takes about 93 seconds to run each time. |
|
@nodejs/testing |
|
@nodejs/collaborators This could use reviews. |
|
@bmeck I don't think these changes invalidate the test or anything, but I would feel a lot more confident about that if you had a chance to take a look and agreed. |
|
So I actually went about deleting due to memory and pushing the limit up to try and speed things up as I was originally trying to get ARM to be happy, these seem fine. |
Trott
force-pushed
the
revise-policy
branch
from
a584db1
to
7fc1a4a
Compare
|
Landed in 7fc1a4a |
* eliminate unneeded Set deletion/cleanup * use number of CPUs as limit for processes spawned rather than hard-coding the limit PR-URL: nodejs#35101 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]>
* eliminate unneeded Set deletion/cleanup * use number of CPUs as limit for processes spawned rather than hard-coding the limit PR-URL: #35101 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]>
* eliminate unneeded Set deletion/cleanup * use number of CPUs as limit for processes spawned rather than hard-coding the limit PR-URL: #35101 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]>
* eliminate unneeded Set deletion/cleanup * use number of CPUs as limit for processes spawned rather than hard-coding the limit PR-URL: nodejs#35101 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]>
hard-coding the limit
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes