Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: change ERR_INVALID_ARG_VALUE error message #35156

Closed
wants to merge 2 commits into from

Conversation

lundibundi
Copy link
Member

Refs: #34682

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added ?
  • commit message follows commit guidelines

/cc @BridgeAR @jasnell @Trott

@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Sep 11, 2020
@lundibundi lundibundi added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2020
@nodejs-github-bot
Copy link
Collaborator

@@ -12,7 +12,7 @@ const dnsPromises = require('dns').promises;
{
code: 'ERR_INVALID_ARG_VALUE',
name: 'TypeError',
message: `The argument 'rrtype' is invalid. Received '${rrtype}'`
message: `The 'rrtype' is invalid. Received '${rrtype}' argument`
Copy link
Member

@Trott Trott Sep 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like argument ended up in the wrong place in this string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch. Do we have a make command to run all tests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make test-all-suites

I would have used make test-all but it was already taken.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@lundibundi
Copy link
Member Author

ping @BridgeAR @jasnell @Trott

@aduh95
Copy link
Contributor

aduh95 commented Sep 19, 2023

This would need a rebase.

@aduh95 aduh95 added the stalled Issues and PRs that are stalled. label Sep 19, 2023
@github-actions
Copy link
Contributor

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

Copy link
Contributor

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. stalled Issues and PRs that are stalled.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants