doc: change type of child_process.signalCode to string #35223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
child_process
Merged
10 tasks
SimplyLinn
changed the title
|
Further testing confirms the same behavior on: node v6.17.1 (linux) |
addaleax
approved these changes
Sep 16, 2020
addaleax
added
the
author ready
Trott
approved these changes
Sep 24, 2020
During testing, and interfacing with child_processes, I found that the child_process.signalCode property to be the string representation of the signal, not number. PR-URL: nodejs#35223 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in e36ffb7. Thanks for the contribution! 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 24, 2020
During testing, and interfacing with child_processes, I found that the child_process.signalCode property to be the string representation of the signal, not number. PR-URL: #35223 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
During testing, and interfacing with child_processes, I found that the child_process.signalCode property to be the string representation of the signal, not number. PR-URL: nodejs#35223 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing, and interfacing with child_processes, I found that the child_proccess.signalCode property to be the string representation of the signal, not number.
Tested on node v14.6.0 (Windows)
Tested on node v14.9.0 (Linux)
Sample code:
Checklist