Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Setting the encoding to hex before piping the hash #35338

Merged
merged 1 commit into from
Sep 27, 2020
Merged

doc: Setting the encoding to hex before piping the hash #35338

merged 1 commit into from
Sep 27, 2020

Commits on Sep 27, 2020

  1. doc: set encoding to hex before piping hash 

    I found out that piping a hash to the stdout output would print a
non-hex set of characters, however, the examples are intended to print
out a hex-encoded output so, my proposal here is simple, we set the
encoding to `hex` before piping the response of the hash algo by calling
`hash.setEncoding('hex');`. With this the example is fixed

PR-URL: nodejs#35338
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
    @vbarzana @Trott
    vbarzana authored and Trott committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    c15a227 View commit details
    Browse the repository at this point in the history