Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add pythonenv to .gitignore #35389

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Conversation

targos
Copy link
Member

@targos targos commented Sep 28, 2020

GitHub Codespaces installs a copy of Python 3.8 in the repository.

image

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 28, 2020
@gengjiawen
Copy link
Member

Still waiting for my github workspace 😭

GitHub Codespaces installs a copy of Python 3.8 in the repository.

PR-URL: nodejs#35389
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott Trott merged commit e2475d5 into nodejs:master Sep 30, 2020
@Trott
Copy link
Member

Trott commented Sep 30, 2020

Landed in e2475d5

@targos targos deleted the ignore-pythonenv branch September 30, 2020 13:27
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
GitHub Codespaces installs a copy of Python 3.8 in the repository.

PR-URL: #35389
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 6, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
GitHub Codespaces installs a copy of Python 3.8 in the repository.

PR-URL: nodejs#35389
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants