src: fix aliased buffer import warning in node_perf_common.h #35436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
yashLadha
force-pushed
the
fix/aliased_buffer_import
branch
from
139c82c
to
68520ff
Compare
joyeecheung
reviewed
Oct 1, 2020
src/node_perf_common.h
Outdated
| @@ -1,6 +1,7 @@ | |||
| #ifndef SRC_NODE_PERF_COMMON_H_ | |||
| #define SRC_NODE_PERF_COMMON_H_ | |||
|
|
|||
| #include "aliased_buffer.h" | |||
There was a problem hiding this comment.
Can you put this before the #include "node.h" line below?
There was a problem hiding this comment.
Sure, but any particular reason for this changes? Is it because of the NODE_WANT_INTERNALS?
There was a problem hiding this comment.
@yashLadha Yes in case anyone including this header accidentally include headers they don't want (there aren't any in aliased_buffer.h for now, but it could be if we don't follow this pattern :) like what this PR used to do)
yashLadha
force-pushed
the
fix/aliased_buffer_import
branch
from
68520ff
to
48b73d7
Compare
gireeshpunathil
approved these changes
Oct 1, 2020
yashLadha
changed the title
jasnell
approved these changes
Oct 1, 2020
joyeecheung
approved these changes
Oct 3, 2020
Trott
approved these changes
Oct 3, 2020
github-actions
bot
removed
the
request-ci
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 5, 2020
Alliased buffer header is not imported in the `env.h` file due to which the language server is giving an error. Fixed it via importing the header file for "aliased_buffer.h" PR-URL: nodejs#35436 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Trott
force-pushed
the
fix/aliased_buffer_import
branch
from
48b73d7
to
e4dc7f7
Compare
|
Landed in e4dc7f7 |
Merged
danielleadams
pushed a commit
that referenced
this pull request
Oct 6, 2020
Alliased buffer header is not imported in the `env.h` file due to which the language server is giving an error. Fixed it via importing the header file for "aliased_buffer.h" PR-URL: #35436 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Alliased buffer header is not imported in the `env.h` file due to which the language server is giving an error. Fixed it via importing the header file for "aliased_buffer.h" PR-URL: nodejs#35436 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alliased buffer header is not imported in the
node_perf_common.hfile due to whichthe language server is giving an error.
Fixed it via importing the header file for "aliased_buffer.h"
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes