Update sxa's email address to Red Hat from IBM #35442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshithaKP
approved these changes
Oct 1, 2020
richardlau
approved these changes
Oct 1, 2020
AshCripps
approved these changes
Oct 1, 2020
Trott
approved these changes
Oct 1, 2020
cjihrig
approved these changes
Oct 1, 2020
|
Good shout @richardlau - now updated mailmap too |
sxa
force-pushed
the
sxa_redhat
branch
2 times, most recently
from
7e1d181
to
f90bd6f
Compare
richardlau
approved these changes
Oct 1, 2020
Signed-off-by: Stewart Addison <[email protected]>
github-actions
bot
removed
the
request-ci
lpinca
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/35442 ✔ Done loading data for nodejs/node/pull/35442 ----------------------------------- PR info ------------------------------------ Title Update sxa's email address to Red Hat from IBM (#35442) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch sxa:sxa_redhat -> nodejs:master Labels doc, fast-track Commits 1 - doc: update sxa's email address to Red Hat from IBM Committers 1 - Stewart X Addison PR-URL: https://github.com/nodejs/node/pull/35442 Reviewed-By: Harshitha K P Reviewed-By: Richard Lau Reviewed-By: Ash Cripps Reviewed-By: Rich Trott Reviewed-By: Colin Ihrig Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35442 Reviewed-By: Harshitha K P Reviewed-By: Richard Lau Reviewed-By: Ash Cripps Reviewed-By: Rich Trott Reviewed-By: Colin Ihrig Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - doc: update sxa's email address to Red Hat from IBM ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-10-04T06:24:54Z: https://ci.nodejs.org/job/node-test-pull-request/33366/ - Querying data for job/node-test-pull-request/33366/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Thu, 01 Oct 2020 09:48:04 GMT ✔ Approvals: 6 ✔ - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/35442#pullrequestreview-500201943 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35442#pullrequestreview-500536466 ✔ - Ash Cripps (@AshCripps): https://github.com/nodejs/node/pull/35442#pullrequestreview-500281727 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35442#pullrequestreview-500357823 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/35442#pullrequestreview-500360211 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/35442#pullrequestreview-500445929 ℹ This PR is being fast-tracked -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
github-actions
bot
added
the
commit-queue-failed
lpinca
approved these changes
Oct 4, 2020
lpinca
pushed a commit
that referenced
this pull request
Oct 4, 2020
Signed-off-by: Stewart Addison <[email protected]> PR-URL: #35442 Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 190ee53. |
Merged
danielleadams
pushed a commit
that referenced
this pull request
Oct 6, 2020
Signed-off-by: Stewart Addison <[email protected]> PR-URL: #35442 Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
Signed-off-by: Stewart Addison <[email protected]> PR-URL: #35442 Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
Signed-off-by: Stewart Addison <[email protected]> PR-URL: #35442 Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Signed-off-by: Stewart Addison <[email protected]> PR-URL: nodejs#35442 Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change of employer so adjusting email address (and adding pronouns)
Signed-off-by: Stewart Addison [email protected]
Checklist