Feature/dns caa #35466

lxdicted · 2020-10-02T16:45:31Z

net: Added support for resolving DNS CAA records (RFC 8659)

This adds support for DNS Certification Authority Authorization (RFC 8659) to nodejs.

Fixes: #19239
Refs: #14713

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

This adds support for DNS Certification Authority Authorization (RFC 6844) to nodejs. This closes nodejs#19239 and possibly affects nodejs#14713.

nodejs-github-bot · 2020-10-02T16:45:36Z

Review requested:

@nodejs/net

doc/api/dns.md

deps/cares/cares.gyp

lxdicted · 2020-10-03T09:52:21Z

@rvagg @nodejs/modules please review the c-ares backport.

Trott · 2020-10-03T13:26:31Z

@nodejs/dns

doc/api/dns.md

addaleax · 2020-10-03T17:43:04Z

src/cares_wrap.cc

+                      env->type_string(),
+                      env->dns_caa_string()).Check();
+
+    ret->Set(context, i + offset, caa_record).Check();


Can you leave a todo comment to do proper exception handling in this method?

There is no exception handling in cares_wrap.cc. If this was needed, it would have been added for all parsing the other record types, too. I don't see a todo here.

There is no exception handling in cares_wrap.cc.

Right, it’s missing, so it would be nice to have a comment about that somewhere in the file

test/internet/test-dns.js

nodejs-github-bot · 2020-10-04T11:21:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33376/

doc/api/dns.md

aduh95 · 2020-10-16T08:26:08Z

Landed in 6f34498

This adds support for DNS Certification Authority Authorization (RFC 8659) to Node.js. PR-URL: #35466 Fixes: #19239 Refs: #14713 Reviewed-By: Anna Henningsen <[email protected]>

AdamMajer · 2020-10-19T14:06:20Z

FWIW, this pulls c-ares patch that is not yet released which will break Node on systems where c-ares is linked as an external dependency. For this reason, I think this should not be backported to currently released versions.

AdamMajer · 2020-10-22T11:57:52Z

The don't-land-on-v15.x actually already happened. It's in 15.0.0+ in 6f34498

aduh95 · 2020-10-22T12:23:19Z

Indeed! Do you think that should be reverted on v15 or do you think it's fine as is?

AdamMajer · 2020-10-22T16:33:20Z

For me it's OK since we will not be shipping 15 with anything and by the time 16 rolls around we can either patch our c-ares for the extra functionality or have a new c-ares version by then.

Trott · 2020-11-04T19:41:54Z

Unfortunately, this broke a test in test/internet (which only get run nightly and I only got around to bisecting today):

node:internal/process/promises:218
          triggerUncaughtException(err, true /* fromPromise */);
          ^

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert.ok(Array.isArray(result[0]))

    at validateResult (/Users/trott/io.js/test/internet/test-dns.js:404:12)
    at test_resolveCaa (/Users/trott/io.js/test/internet/test-dns.js:411:3) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}

Bug in the test? Bug in this change? Something else?

Trott · 2020-11-04T19:53:02Z

Oh, interesting, the test that is failing was added in this PR.

Is the bug that it should be checking Array.isArray(result) and not Array.isArray(result[0])?

Trott · 2020-11-04T19:54:07Z

Oh, interesting, the test that is failing was added in this PR.

Is the bug that it should be checking Array.isArray(result) and not Array.isArray(result[0])?

Yeah, looking at the surrounding code, that's gotta be it.

Trott · 2020-11-04T20:00:33Z

Fix in #35969

Refs: nodejs#35466 (comment) PR-URL: nodejs#35969 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

Refs: #35466 (comment) PR-URL: #35969 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

lxdicted · 2020-11-20T16:42:07Z

@AdamMajer , @aduh95 : c-ares 0.17.1 has been released recently. It there any change to get this into v10, v12, or v14?

AdamMajer · 2020-11-20T16:49:32Z

I think no problem here to backport this to older versions now.

richardlau · 2020-11-20T16:54:37Z

@AdamMajer , @aduh95 : c-ares 0.17.1 has been released recently. It there any change to get this into v10, v12, or v14?

10.x is in maintenance so this won't land there. The last planned 12.x release before it enters maintenance at the end of the month is due on Tuesday (#35950 ) so the chance of getting this into 12.x is low.

For 14.x the path forwards should be to update c-ares in master to 0.17.1 and then backport that together with this PR to 14.x.

lxdicted · 2020-11-24T06:27:03Z

I've created a pull request for c-ares 1.17.1 here: #36207

lxdicted · 2020-12-19T09:05:04Z

For 14.x the path forwards should be to update c-ares in master to 0.17.1 and then backport that together with this PR to 14.x.

@richardlau c-ares 1.17.1 has landed in 3bd9b81, any other obstacles to backport this to 14.x?

richardlau · 2020-12-21T11:50:22Z

For 14.x the path forwards should be to update c-ares in master to 0.17.1 and then backport that together with this PR to 14.x.

@richardlau c-ares 1.17.1 has landed in 3bd9b81, any other obstacles to backport this to 14.x?

Our general policy is that for LTS release lines (e.g. 14.x) a change should live on the current release (i.e. 15.x) for two weeks before being backported (https://github.com/nodejs/Release#lts-staging-branches). 3bd9b81 hasn't gone out in 15.x yet (the next 15.x release is planned for this week, nodejs/Release#621). The next 14.x release is going to be a security release (https://nodejs.org/en/blog/vulnerability/january-2021-security-releases/) so any backports of features would have to wait until after that. We haven't firmly sketched out the release plan for 14.x for next year, but have discussed planning a semver-minor for mid to late January.

So timeline wise:

3bd9b81 goes out in a 15.x release.
Two weeks after the 15.x release the c-ares update lands on v14.x-staging.
This PR is backported, minus the c-ares floating patch (as the intention is to use the proper c-ares update) and including test: fix error in test/internet/test-dns.js #35969 (fixing up one of the testcases). I've added a backport-requested-v14.x label.

This adds support for DNS Certification Authority Authorization (RFC 8659) to Node.js. PR-URL: #35466 Fixes: #19239 Refs: #14713 Reviewed-By: Anna Henningsen <[email protected]>

Refs: #35466 (comment) PR-URL: #35969 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

lxdicted added 2 commits October 2, 2020 18:30

Backport CAA parsing from c-ares

b5de9b4

Added support for resolving DNS CAA records

08d2e88

This adds support for DNS Certification Authority Authorization (RFC 6844) to nodejs. This closes nodejs#19239 and possibly affects nodejs#14713.

lxdicted requested a review from a team as a code owner October 2, 2020 16:45

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 2, 2020

lxdicted added 2 commits October 2, 2020 18:49

Fixed a typo

5a08eaa

Whitespace changes

9218871

mscdex reviewed Oct 2, 2020

View reviewed changes

doc/api/dns.md Outdated Show resolved Hide resolved

mscdex reviewed Oct 2, 2020

View reviewed changes

deps/cares/cares.gyp Outdated Show resolved Hide resolved

lxdicted added 4 commits October 2, 2020 19:15

Added missing types

eaafda6

Partially reverted change

71f350b

Documentation update

bb9a6ec

MacOS compile fix

87db47d

Trott added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 3, 2020

addaleax approved these changes Oct 3, 2020

View reviewed changes

lxdicted added 2 commits October 4, 2020 11:32

Fixed documentation version

5e52515

Allow parsing of CAA records when queying ANY

d1e115f

addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. review wanted PRs that need reviews. labels Oct 4, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020

mscdex reviewed Oct 4, 2020

View reviewed changes

doc/api/dns.md Outdated Show resolved Hide resolved

Documentation update

1e18c47

aduh95 closed this Oct 16, 2020

richardlau added the dont-land-on-v14.x label Oct 19, 2020

aduh95 added the dont-land-on-v15.x label Oct 19, 2020

aduh95 removed the dont-land-on-v15.x label Oct 22, 2020

augjoh mentioned this pull request Oct 23, 2020

Allow parsing of CAA Resource Record (Closes #292) c-ares/c-ares#360

Merged

Trott mentioned this pull request Nov 4, 2020

test: fix error in test/internet/test-dns.js #35969

Merged

2 tasks

richardlau added backport-requested-v14.x and removed dont-land-on-v14.x labels Dec 21, 2020

targos removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v14.x review wanted PRs that need reviews. labels Apr 30, 2021

danielleadams mentioned this pull request May 3, 2021

v14.17.0 proposal #38507

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/dns caa #35466

Feature/dns caa #35466

lxdicted commented Oct 2, 2020 •

edited

Loading

nodejs-github-bot commented Oct 2, 2020

lxdicted commented Oct 3, 2020

Trott commented Oct 3, 2020

addaleax Oct 3, 2020

lxdicted Oct 4, 2020

addaleax Oct 4, 2020

nodejs-github-bot commented Oct 4, 2020

aduh95 commented Oct 16, 2020

AdamMajer commented Oct 19, 2020

AdamMajer commented Oct 22, 2020

aduh95 commented Oct 22, 2020

AdamMajer commented Oct 22, 2020

Trott commented Nov 4, 2020 •

edited

Loading

Trott commented Nov 4, 2020

Trott commented Nov 4, 2020

Trott commented Nov 4, 2020

lxdicted commented Nov 20, 2020

AdamMajer commented Nov 20, 2020

richardlau commented Nov 20, 2020

lxdicted commented Nov 24, 2020

lxdicted commented Dec 19, 2020

richardlau commented Dec 21, 2020

Feature/dns caa #35466

Feature/dns caa #35466

Conversation

lxdicted commented Oct 2, 2020 • edited Loading

net: Added support for resolving DNS CAA records (RFC 8659)

Checklist

nodejs-github-bot commented Oct 2, 2020

lxdicted commented Oct 3, 2020

Trott commented Oct 3, 2020

addaleax Oct 3, 2020

Choose a reason for hiding this comment

lxdicted Oct 4, 2020

Choose a reason for hiding this comment

addaleax Oct 4, 2020

Choose a reason for hiding this comment

nodejs-github-bot commented Oct 4, 2020

aduh95 commented Oct 16, 2020

AdamMajer commented Oct 19, 2020

AdamMajer commented Oct 22, 2020

aduh95 commented Oct 22, 2020

AdamMajer commented Oct 22, 2020

Trott commented Nov 4, 2020 • edited Loading

Trott commented Nov 4, 2020

Trott commented Nov 4, 2020

Trott commented Nov 4, 2020

lxdicted commented Nov 20, 2020

AdamMajer commented Nov 20, 2020

richardlau commented Nov 20, 2020

lxdicted commented Nov 24, 2020

lxdicted commented Dec 19, 2020

richardlau commented Dec 21, 2020

lxdicted commented Oct 2, 2020 •

edited

Loading

Trott commented Nov 4, 2020 •

edited

Loading