add a subsystems header in pull-requests.md #35718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
Trott
approved these changes
Oct 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #35718 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 220 220
Lines 73675 73676 +1
=======================================
+ Hits 71025 71028 +3
+ Misses 2650 2648 -2
Continue to review full report at Codecov.
|
PoojaDurgad
force-pushed
the
subsystem
branch
from
0fb519a
to
656531c
Compare
Trott
approved these changes
Oct 21, 2020
jasnell
approved these changes
Oct 26, 2020
gireeshpunathil
approved these changes
Oct 27, 2020
gireeshpunathil
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 16b2bc0...8f1e4d3 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 27, 2020
PR-URL: #35718 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35718 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
PR-URL: #35718 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #35718 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #35718 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes