Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.x backport] module: remove experimental modules warning #35749

Closed
wants to merge 1 commit into from
Closed

[12.x backport] module: remove experimental modules warning #35749

wants to merge 1 commit into from

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Oct 22, 2020 •
edited
Loading

This backports the PR with the removal of the experimental warning from #31974.

This seems important as many users are unaware the 12.x implementation provides the same stable base-level modules functionality.

It would be nice to get the approvals here in the mean time, but this should probably only land once the two previously left out backports from the last 12 release have landed:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@guybedford
module: remove experimental modules warning
0079c11 
PR-URL: nodejs#31974
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jan Krems <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@nodejs-github-bot nodejs-github-bot added process Issues and PRs related to the process subsystem. v12.x labels Oct 22, 2020
This was referenced Oct 22, 2020
Merged
Closed
@guybedford
Copy link
Contributor Author

guybedford commented Oct 23, 2020 •
edited
Loading

Superseded by #35757.

@guybedford guybedford closed this Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guybedford @targos @aduh95 @nodejs-github-bot