Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing link in Node.js 14 Changelog #35782

Merged
merged 1 commit into from
Oct 24, 2020

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 23, 2020

The link to Node.js 14.13.1 was missing from the index table.

Refs: #35525

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 23, 2020
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 23, 2020
@aduh95
Copy link
Contributor Author

aduh95 commented Oct 23, 2020

fast-track?

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 24, 2020
Refs: nodejs#35525

PR-URL: nodejs#35782
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@Trott Trott merged commit 4ab6628 into nodejs:master Oct 24, 2020
@Trott
Copy link
Member

Trott commented Oct 24, 2020

Landed in 4ab6628

richardlau pushed a commit that referenced this pull request Oct 26, 2020
Refs: #35525

PR-URL: #35782
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@richardlau richardlau mentioned this pull request Oct 27, 2020
4 tasks
targos pushed a commit that referenced this pull request Nov 3, 2020
Refs: #35525

PR-URL: #35782
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@targos targos mentioned this pull request Nov 3, 2020
@aduh95 aduh95 deleted the fix-node14-changelog branch July 16, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants