crypto: fixup scrypt regressions #35821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a handful of regressions in scrypt support following the refactor. Fixes: nodejs#35815
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
added
crypto
addaleax
approved these changes
Oct 26, 2020
github-actions
bot
removed
the
request-ci
jasnell
added
the
author ready
tniessen
approved these changes
Oct 26, 2020
github-actions
bot
removed
the
request-ci
Trott
approved these changes
Oct 27, 2020
aduh95
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 30e9fab...05bb1b3 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 30, 2020
Fixes a handful of regressions in scrypt support following the refactor. Fixes: #35815 PR-URL: #35821 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Fixes a handful of regressions in scrypt support following the refactor. Fixes: #35815 PR-URL: #35821 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Nov 4, 2020
2 tasks
lpinca
pushed a commit
that referenced
this pull request
Nov 5, 2020
PR-URL: #35972 Refs: #35821 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
PR-URL: #35972 Refs: #35821 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a handful of regressions in scrypt support following
the refactor.
Fixes: #35815
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes