assert,repl: enable ecmaVersion 2021 in acorn parser #35827
Conversation
This adds support for the new logical assignment operators.
nodejs-github-bot
added
assert
github-actions
bot
removed
the
request-ci
I'm not sure that's worth the effort. |
There was a problem hiding this comment.
I suggest to use latest instead to prevent future updates. This is a recent feature added to acorn (https://github.com/acornjs/acorn/tree/master/acorn#interface).
Is that not going to cause maintenance issues when the code ends up in release lines? |
I am not certain I fully understand the comment. AFAIK the suggestion should minimize the maintenance need due to always providing the latest features acorn supports. Thus, there should be no need for a PR like this one after upgrading acorn. |
I mean that, say, we cut Node.js 16 with it set to |
That should not be an issue: it would fail execution in the REPL and assert would not be able to execute the code in the first place if it would not be supported. But it's actually very unlikely to even get to that: we'd have to update acorn without noticing it already supporting features that Node.js does not and that has never happened before as far as I can tell. Acorn only supports features that are stable and we'd have to lack behind on updating V8 quite a lot for it to happen. |
¯\_(ツ)_/¯ I'm going off #35791 (comment) which implied that this PR shouldn't be backported to Node.js 14. |
Co-authored-by: Ruben Bridgewater <[email protected]>
targos
added
request-ci
|
@BridgeAR convinced me that it should not be an issue if Acorn supports more syntax than V8. |
github-actions
bot
removed
the
request-ci
targos
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 87a6b60...0ddd69e |
This adds support for the new logical assignment operators. PR-URL: #35827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This adds support for the new logical assignment operators. PR-URL: #35827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This adds support for the new logical assignment operators. PR-URL: #35827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This adds support for the new logical assignment operators. PR-URL: #35827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This adds support for the new logical assignment operators. PR-URL: #35827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This adds support for the new logical assignment operators.