Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove flaky designation for fixed test #35961

Merged
merged 1 commit into from
Nov 12, 2020
Merged

test: remove flaky designation for fixed test #35961

merged 1 commit into from
Nov 12, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 4, 2020

Remove flaky designation for test-worker-eventlooputil fixed in 9dbde1d.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 4, 2020
@Trott Trott requested a review from Flarna November 4, 2020 13:02
@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 4, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Flarna
Flarna approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I should have done that in my PR.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Flarna Flarna added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Flarna
Copy link
Member

Flarna commented Nov 5, 2020 •
edited
Loading

maybe we should wait a little with this. I have just seen another fail: https://ci.nodejs.org/job/node-test-commit-osx/37136/

Hmm, stress test was green so maybe a single event
https://ci.nodejs.org/view/Stress/job/node-stress-single-test/197/

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/34102/ ✅

Trott added a commit to Trott/io.js that referenced this pull request Nov 6, 2020
@Trott
test: move test-worker-eventlooputil to sequential
96f7900 
The test is not nearly as unreliable as it used to be but we're still
seeing failures around the timing checks that will definitely be
affected by other tests running in other processes. So move it to
sequential.

Refs: nodejs#35961 (comment)
@Trott Trott mentioned this pull request Nov 6, 2020
Closed
2 tasks
@Trott
Copy link
Member Author

Trott commented Nov 6, 2020

maybe we should wait a little with this. I have just seen another fail: https://ci.nodejs.org/job/node-test-commit-osx/37136/

Oh, yeah, that timing sensitivity with those millisecond magic numbers is definitely going to be affected by being in the parallel directory. The test needs to be re-written to not be dependent on "must happen within 10 milliseconds" type logic or else (the more likely result) moved to sequential.

Pull request to do just that: #35996

@Trott
test: remove flaky designation for fixed test
55b1718 
Remove flaky designation for test-worker-eventlooputil fixed in 9dbde1d.

PR-URL: nodejs#35961
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member Author

Trott commented Nov 12, 2020

Landed in 55b1718

@Trott Trott merged commit 55b1718 into nodejs:master Nov 12, 2020
@Trott Trott deleted the rm-fixed branch November 12, 2020 13:35
nodejs-github-bot pushed a commit that referenced this pull request Nov 12, 2020
@Trott @nodejs-github-bot
test: move test-worker-eventlooputil to sequential
660265e 
The test is not nearly as unreliable as it used to be but we're still
seeing failures around the timing checks that will definitely be
affected by other tests running in other processes. So move it to
sequential.

Refs: #35961 (comment)

PR-URL: #35996
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@Trott @BethGriggs
test: remove flaky designation for fixed test
e1d1f5e 
Remove flaky designation for test-worker-eventlooputil fixed in 9dbde1d.

PR-URL: #35961
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@Trott @BethGriggs
test: remove flaky designation for fixed test
b7d8d61 
Remove flaky designation for test-worker-eventlooputil fixed in 9dbde1d.

PR-URL: #35961
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@Trott @BethGriggs
test: remove flaky designation for fixed test
b05cdfe 
Remove flaky designation for test-worker-eventlooputil fixed in 9dbde1d.

PR-URL: #35961
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: move test-worker-eventlooputil to sequential
6c62e15 
The test is not nearly as unreliable as it used to be but we're still
seeing failures around the timing checks that will definitely be
affected by other tests running in other processes. So move it to
sequential.

Refs: #35961 (comment)

PR-URL: #35996
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@Flarna Flarna Flarna approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @Flarna @lpinca @richardlau @gireeshpunathil @ZYSzys