Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: fix to inspect getters that access this #36052

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

RaisinTen
Copy link
Contributor

@RaisinTen RaisinTen commented Nov 9, 2020

Fixes: #36045

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Nov 9, 2020
lib/internal/util/inspect.js Outdated Show resolved Hide resolved
@RaisinTen RaisinTen marked this pull request as ready for review November 9, 2020 18:03
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 10, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

Fixes: nodejs#36045

Co-authored-by: Antoine du Hamel <[email protected]>

PR-URL: nodejs#36052
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 12, 2020

Landed in 929c51f

@Trott Trott merged commit 929c51f into nodejs:master Nov 12, 2020
@RaisinTen RaisinTen deleted the fix-util-inspect-getter branch November 12, 2020 13:44
@szmarczak
Copy link
Member

Big thanks @RaisinTen 🎉

@RaisinTen
Copy link
Contributor Author

@szmarczak you're welcome. 🙂

codebytere pushed a commit that referenced this pull request Nov 22, 2020
Fixes: #36045

Co-authored-by: Antoine du Hamel <[email protected]>

PR-URL: #36052
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Nov 22, 2020
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
Fixes: #36045

Co-authored-by: Antoine du Hamel <[email protected]>

PR-URL: #36052
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
Fixes: #36045

Co-authored-by: Antoine du Hamel <[email protected]>

PR-URL: #36052
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
Fixes: #36045

Co-authored-by: Antoine du Hamel <[email protected]>

PR-URL: #36052
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

util.inspect fails to log getters which access this
6 participants